Get rid of some more magic numbers #200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the defined constants for indirect matrix indexes. Note that the changes to the comparison operators are compensated by the +/-1 offset in the operand, so the end result is unaltered.
The old code suffered from some obfuscation due to how it was reverse engineered: - The 0x43300000 magix number is the binary representation of the upper 32 bits of a double floating point number havint the exponent set to 1075, which makes it so that the least significant bit of the lower 32 bit word maps exactly to the unit 1. - 4503599627370496.0F is 1 << 52, which in floating point representation is 0x43300000 00000000. - 0.00097656250F is "1.0 / (1 << 10)" In other words: multiplying by 0.00097656250F is equivalent to dividing by 2^10, and this is the actual operation that the old code was fulfilling. The subtraction between the double floating point numbers is just an optimisation to convert the integer parameter into a float, so we can safely ignore it and leave it all to the compiler.
DacoTaco
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review it commit by commit, because the commit messages should help in understanding what is happening :-)