Fix: Resolve Issue #9 [Authentication System] and #12 [CORS Error] #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aradhya2708
changed the title
| return | ||
| } | ||
|
|
||
| defer client.Close() |
There was a problem hiding this comment.
I see this problematic, I have checked it, this will be nice for single user system, but if concurrent req are made and all try to close the same client(here global client), so from 2nd req onwards they are processing this on closed client.
What you can do , create new client for each request inside that function and then defer closing it. Or something else.
Otherwise it is nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Resolve Issue #9 [Authentication System] and #12 [CORS Error]
Created a basic working LDAP client system for User Authentication
Example Correct Usage (testing):