state consistency nits

devsnek · Feb 1, 2020 · 5b65fc7 · 5b65fc7
1 parent 39ea85a
commit 5b65fc7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/engines/javascriptcore.js b/src/engines/javascriptcore.js
@@ -33,7 +33,7 @@ class JavaScriptCoreInstaller extends Installer {
     if (platform.startsWith('win')) {
       return false;
     }
-    return this.isSupported();
+    return super.shouldInstallByDefault();
   }
 
   static async resolveVersion(version) {

diff --git a/src/installer.js b/src/installer.js
@@ -115,9 +115,11 @@ class EngineInstaller {
 
     // Delete bin entries and engine assets
     await Promise.all([
-      status.installed[this.config.id].binEntries
-        && status.installed[this.config.id].binEntries.map((b) =>
-          fs.promises.unlink(path.join(ESVU_PATH, 'bin', b))),
+      status.installed[this.config.id]
+      && status.installed[this.config.id].binEntries
+      && status.installed[this.config.id].binEntries.map((b) =>
+        fs.promises.unlink(path.join(ESVU_PATH, 'bin', b))),
+
       rmdir(path.join(ESVU_PATH, 'engines', this.config.id)),
     ]);