FEAT: support idleReplicaCount=0 rendering in Rollout Deployment KEDA template#6972
Open
lokesh-devtron wants to merge 1 commit into
Open
FEAT: support idleReplicaCount=0 rendering in Rollout Deployment KEDA template#6972lokesh-devtron wants to merge 1 commit into
lokesh-devtron wants to merge 1 commit into
Conversation
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Type of change
Description
Problem Statement
When
kedaAutoscaling.idleReplicaCountis configured with the value0, the generated KEDAScaledObjectdoes not render theidleReplicaCountfield.The existing Helm template uses the following condition:
Since Helm evaluates
0as a false value, the condition fails and the field is omitted from the rendered manifest.As a result, users cannot explicitly configure:
even when it is provided in the deployment template values.
Root Cause
The template checks the truthiness of the value instead of checking whether the value is defined.
Fix
Updated the template condition to explicitly check for
nil:This ensures that:
idleReplicaCount: 0is rendered correctly.Additionally, added the default
idleReplicaCount: 0invalues.yamlfor consistency.Testing
when configured in values.
Impact
This change preserves existing behavior while correctly supporting explicit zero values for
idleReplicaCount.Summary by Bito