Skip to content

[Snyk] Security upgrade urllib3 from 1.26.13 to 2.6.0 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dextrorsal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade urllib3 from 1.26.13 to 2.6.0 #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ tomli==2.0.1
toolz==0.11.2
types-cachetools==4.2.10
typing_extensions==4.4.0
urllib3==1.26.13
urllib3==2.6.0
Copy link

@sentry sentry bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: requests 2.28.1 is incompatible with urllib3 2.6.0 due to removed HTTPResponse methods, leading to AttributeError.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

When requests 2.28.1 attempts to make an HTTP request using urllib3 2.6.0, it will encounter an AttributeError because urllib3 2.6.0 has removed the HTTPResponse.getheader() and HTTPResponse.getheaders() methods that requests 2.28.1 expects to call internally. This will cause the application to crash at runtime whenever an HTTP request is made.

💡 Suggested Fix

Upgrade the requests library to version 2.30.0 or later to ensure compatibility with urllib3 2.6.0.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: requirements.txt#L63

Potential issue: When `requests 2.28.1` attempts to make an HTTP request using `urllib3
2.6.0`, it will encounter an `AttributeError` because `urllib3 2.6.0` has removed the
`HTTPResponse.getheader()` and `HTTPResponse.getheaders()` methods that `requests
2.28.1` expects to call internally. This will cause the application to crash at runtime
whenever an HTTP request is made.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 6095916

websockets==10.4
yarl==1.8.2
zstandard==0.17.0