Skip to content

[Snyk] Fix for 9 vulnerabilities #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dextrorsal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 9 vulnerabilities #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
aiodns==3.0.0
aiohttp==3.8.3
aiohttp==3.13.3
aiosignal==1.3.1
anchorpy==0.20.1
anchorpy-core==0.2.0
Expand Down Expand Up @@ -60,7 +60,7 @@ tomli==2.0.1
toolz==0.11.2
types-cachetools==4.2.10
typing_extensions==4.4.0
urllib3==1.26.13
urllib3==2.6.3
Copy link
Copy Markdown

@sentry sentry bot Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The update to urllib3==2.6.3 is incompatible with the pinned requests==2.28.1, which requires urllib3<2.0.
Severity: CRITICAL

🔍 Detailed Analysis

The requirements.txt file pins requests==2.28.1 while upgrading urllib3 to version 2.6.3. According to package metadata, requests==2.28.1 has a strict dependency requirement of urllib3>=1.21.1,<2. This version conflict will likely cause dependency resolution to fail or lead to runtime errors when requests is used. Critical functions like get_jupiter_swap_ix_v6() in src/driftpy/drift_client.py, which rely on requests.get() and requests.post(), will fail, breaking the Jupiter swap functionality.

💡 Suggested Fix

To resolve the incompatibility, either downgrade urllib3 to a version below 2.0 that is compatible with requests==2.28.1, or upgrade requests to a more recent version (e.g., requests>=2.30.0) that officially supports urllib3>=2.0.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: requirements.txt#L63

Potential issue: The `requirements.txt` file pins `requests==2.28.1` while upgrading
`urllib3` to version `2.6.3`. According to package metadata, `requests==2.28.1` has a
strict dependency requirement of `urllib3>=1.21.1,<2`. This version conflict will likely
cause dependency resolution to fail or lead to runtime errors when `requests` is used.
Critical functions like `get_jupiter_swap_ix_v6()` in `src/driftpy/drift_client.py`,
which rely on `requests.get()` and `requests.post()`, will fail, breaking the Jupiter
swap functionality.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8467191

websockets==10.4
yarl==1.8.2
zstandard==0.17.0