creative items changes #1014
Open
creative items changes #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
^ |
|
@TwistedAsylumMC this pr is still waiting for you -_- |
TwistedAsylumMC
requested changes
Mar 24, 2025
| // creativeItemStacks holds a list of all item stacks that were registered to the creative inventory using | ||
| // RegisterItem. | ||
| creativeItemStacks []Item | ||
| // items holds a list of all item stacks that were registered to the creative inventory. |
There was a problem hiding this comment.
They are not item stacks at this point
Comment on lines
-57
to
-60
| // RegisterItem registers an item as a creative item, exposing it in the creative inventory. | ||
| func RegisterItem(item Item) { | ||
| creativeItemStacks = append(creativeItemStacks, item) | ||
| } |
There was a problem hiding this comment.
Not sure why this was removed, as I said on discord:
I dont really know how we should do this, we need a way for people to register their own groups but also inject into vanilla groups
Comment on lines
+173
to
+174
| // itemByIndex returns creative item by index. | ||
| func itemByIndex(groups []creative.Group, index int) (item.Stack, error) { |
There was a problem hiding this comment.
Name and documentation could be better here, document how it works and the case where it returns an error
| for _, group := range creative.Groups() { | ||
| func creativeContent(creativeGroups []creative.Group) ([]protocol.CreativeGroup, []protocol.CreativeItem) { | ||
| groups := make([]protocol.CreativeGroup, 0, len(creativeGroups)) | ||
| it := make([]protocol.CreativeItem, 0, len(creativeGroups)*10) |
There was a problem hiding this comment.
Why are you multiplying by 10?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.