Skip to content

Added a fall manager for entities#549

Open
HashimTheArab wants to merge 15 commits intodf-mc:masterfrom
GrapeDevs:manager/fall
Open

Added a fall manager for entities#549
HashimTheArab wants to merge 15 commits intodf-mc:masterfrom
GrapeDevs:manager/fall

Conversation

@HashimTheArab
Copy link
Contributor

No description provided.

Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Please make sure to fix the issues pointed out by the CI. Also, for future reference, please do add a description for your PR so we can get an idea of the reason for your PR and the changes you've made.

@HashimTheArab
Copy link
Contributor Author

anything else on this?

@JustTalDevelops JustTalDevelops added the improvement Improvement of an existing part of the codebase label Jul 14, 2022
@JustTalDevelops JustTalDevelops changed the title Fall manager Added a fall manager for entities Jul 14, 2022
@JustTalDevelops
Copy link
Member

Would also remove the fall distance calculation code in falling block and make it adopt this system.

@HashimTheArab
Copy link
Contributor Author

Would also remove the fall distance calculation code in falling block and make it adopt this system.

is the latest commit fine?

@Sandertv
Copy link
Member

There is a bit of an awkward "cycle" between this fall manager and the movement computer. Maybe it'd be an idea to merge them?

@HashimTheArab
Copy link
Contributor Author

There is a bit of an awkward "cycle" between this fall manager and the movement computer. Maybe it'd be an idea to merge them?

Could you elaborate more on that

@Sandertv Sandertv added this to the v0.11.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement of an existing part of the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants