Kaia/sdk 2075 uint8 candid interfaces #1012
Draft
+7,360
−1,005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: fix linting * style: fix or disable linter errors * docs: improve jsdocs
#994) * simplifies subtyping on Opt to always succeed with an opt on the right * applies subtype check before decoding functions or services * stores positive/negative subtyping checks in a global cache * don't assume function annotations are sorted * remember failed subtyping checks * clear subtype cache after decoding to avoid leaking space --------- Co-authored-by: Christoph Hegemann <[email protected]> Co-authored-by: Kaia Peacock <[email protected]>
* refactor: use new error system and error codes * test: update throw assertions to use the new error classes * feat: cbor error * test: assert error kind * test: fix e2e and mitm tests for certificate errors * test: remove console logs * fix: remove code and kind props from AgentErrorV2 * feat: der errors * feat: der error on public key * feat: hex decode error * feat: timeout errors * feat: polling errors * feat: canister status errors * feat: hash value errors * refactor: use error kind constructors * refactor: extend class instead of implementing abstract
Co-authored-by: Luca Bertelli <[email protected]> Co-authored-by: Nathan Mc Grath <[email protected]>
…up_subtree` (#1009) * refactor: unreachable error constant * refactor: distinguish between lookup errors * feat: make lookup path compliant with the spec (https://github.com/dfinity/portal/blob/8015a4ab50232176723ffd95e32a02f1bf7fef30/docs/references/ic-interface-spec.md#L3069) * feat!: lookup_subpath and stronger hashtree types * feat!: `lookup_path` and `lookup_subtree` in `Certificate` class * refactor: stronger types on `find_label` * test: cover lookup_path new cases and unreachable errors * chore: update changelog * chore: update changelog to be more specific * chore: minor changelog updates * refactor: rename lookup results * fix: import after renamings * test: fix import after renaming
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: