Skip to content

Web2 auth #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Web2 auth #2442

wants to merge 4 commits into from

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Apr 23, 2024 •
edited by github-actions bot
Loading

🟡 Some screens were changed

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 23, 2024
View reviewed changes
demos/web2-auth/src/auth.ts

// Wait for II to say it's ready
const evnt = await new Promise<MessageEvent>((resolve) => {
const readyHandler = (e: MessageEvent) => {

Check warning

Code scanning / CodeQL

Missing origin verification in `postMessage` handler

Postmessage handler has no origin check.
demos/web2-auth/src/auth.ts

// Wait for the II response and update the local state
const response = await new Promise<MessageEvent>((resolve) => {
const responseHandler = (e: MessageEvent) => {

Check warning

Code scanning / CodeQL

Missing origin verification in `postMessage` handler

Postmessage handler has no origin check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @nmattia