chore: Implement data migration for lookup_application_with_origin_map
#3337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
src/internet_identity/src/migrations/lookup_application_with_origin.rs
Outdated
Show resolved
Hide resolved
lmuntaner
reviewed
Sep 2, 2025
src/internet_identity/src/migrations/lookup_application_with_origin.rs
Outdated
Show resolved
Hide resolved
lmuntaner
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR continues the work towards migrating the
lookup_application_with_originmap's keys from 8-byte prefixes of a full sha-256 sum.< Previous PR |
Changes
post_upgrade.Tests
Integration
upgrade_and_rollback_with_realistic_data_migration- Upgrading the II canister succeeds, migrating 2,000 application-specific user accounts. This test passed locally in 319.35s; if that's not acceptable for the CI, we can reduce the number of accounts in this test to 10, and re-run it locally to gain confidence in the migration.Unit
should_skip_migration_if_new_map_not_empty- When the new map already contains entries, the migration leaves both maps unchanged.should_migrate_single_entry_successfully- Tests successful migration of one application from old hash map to new SHA-256 map, verifying correct return values and final state.should_migrate_multiple_entries_successfully- Tests successful migration of multiple applications, ensuring all entries are properly transferred with correct mappings.should_handle_missing_application_gracefully- Tests behavior when old map references non-existent applications, verifying missing apps are reported in return values and skipped during migration.should_handle_empty_old_map- Tests migration behavior with empty maps, ensuring function returns empty collections and maps remain empty.should_handle_hash_collisions_correctly- Tests collision detection where multiple applications exist in stable storage but only one is in the old map due to hash collision, verifying collision recovery mechanism.