Skip to content

Fix the response from MCP server. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stej wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix the response from MCP server. #10

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43eb799
Fix the response from MCP server.
Feb 16, 2026
ee52fdf
Update Public/Invoke-HandleRequest.ps1
stej Mar 17, 2026
0204bb0
Update Public/Invoke-HandleRequest.ps1
stej Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion Public/Invoke-HandleRequest.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,19 @@ function Invoke-HandleRequest {

$result = & $toolName @targetArgs

$resultText = if ($null -eq $result) {
""
}
elseif ($result -is [string]) {
$result
}
elseif ($result -is [ValueType]) {
$result.ToString()
}
else {
$result | ConvertTo-Json -Depth 100
}
Comment on lines +86 to +108
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are Pester tests for other public entry points (e.g., Register-MCPTool), but none cover Invoke-HandleRequest's tools/call result formatting. Adding tests around this new $resultText branching (null, scalar string, string[], value types, complex objects serialized to JSON) would help prevent MCP response regressions.

Copilot uses AI. Check for mistakes.
Copy link
Author

@stej stej Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

Comment on lines +89 to +108
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$result -is [string] only matches a scalar string. If a tool writes multiple strings (common in PowerShell), $result becomes string[] and will fall into the JSON branch, so the client receives a literal JSON array string (e.g. ["a","b"]) instead of readable text lines. Consider detecting an enumerable of strings (or value types) and joining with newlines / Out-String for those cases, reserving ConvertTo-Json for non-text objects.

Copilot uses AI. Check for mistakes.
Copy link
Author

@stej stej Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback


# Log structured data
Write-Log -LogEntry @{
RequestId = $request.id
Expand All @@ -63,7 +76,7 @@ function Invoke-HandleRequest {
content = @(
[ordered]@{
type = "text"
text = $result | Out-String
text = $resultText
}
)
isError = $false
Expand Down