Configurable Extra connect-src CSP Origins#1599
Open
takwerx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The plugin system makes it easy to build frontend plugins that consume an external data feed — but the nginx CSP is fixed at
connect-src 'self'(plus the API host), so any browserfetch/WebSocketto a third-party origin is blocked by the page's CSP in production. The only workaround today is forking/patchingapi/nginx.conf.jsin the image.Concrete case: a community lightning plugin (Blitzortung websocket feed,
wss://ws*.blitzortung.org) works on a dev build but its socket is CSP-refused on any deployed instance.Change
nginx.conf.jsaccepts an optional space-separatedCSP_CONNECT_SRCenv var whose entries are appended toconnect-src. Entries are validated against a conservative character allowlist ([A-Za-z0-9*.:/-]) so a malformed value cannot break out of the quoted header — invalid entries are logged to stderr and skipped.No behavior change when the variable is unset — the generated config is identical to before.
Testing
🤖 Generated with Claude Code