Skip to content

fix: invalidate favicon cache when clearing watch history - #4286

Open
snowyukitty wants to merge 1 commit into
dgtlmoon:masterfrom
snowyukitty:fix/4277-stale-favicon-cache
Open

fix: invalidate favicon cache when clearing watch history#4286
snowyukitty wants to merge 1 commit into
dgtlmoon:masterfrom
snowyukitty:fix/4277-stale-favicon-cache

Conversation

@snowyukitty

Copy link
Copy Markdown

Summary

  • Evict the module-level favicon filename cache after clear_watch() removes watch history files.
  • Add a regression test that primes the cache, clears history, and verifies the deleted favicon is no longer returned.

Fixes #4277.

Thanks @ebarkhordar for the thorough root-cause analysis and reproduction in #4277.

Testing

  • Regression test fails on upstream master with 'favicon.ico' is not None, then passes with this fix.
  • pytest -q tests/unit/test_watch_model.py — 19 passed
  • pytest -q tests/unit/ tests/llm/ — 340 passed, 30 subtests passed
  • ruff check . --select E9,F63,F7,F82,INT
  • git diff --check

@dgtlmoon

dgtlmoon commented Aug 5, 2026

Copy link
Copy Markdown
Owner

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switching from Playwright back to Basic fetcher, clearing history, leaves stale favicon reference in UI

2 participants