Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer "schema" syntax for examples #93

Merged

Conversation

gregziegan
Copy link
Contributor

@gregziegan gregziegan commented Nov 22, 2019

Our dhall-kubernetes usage has preferred the Schema::{} syntax. Aligning the public documentation with schema usage would be great for on-boarding!

(Just realized the auto-formatter defaulted to unicode characters, would maintainers rather keep ascii?)

@gregziegan
Copy link
Contributor Author

hmm not sure why the hydra check is hanging. I also tried running ./scripts/generate.sh but the nix build failed with

Setup: Encountered missing dependencies:
QuickCheck >=2.7 && <2.13

... and fix `./scripts/generate.sh` to generate the `schemas*` files
@Gabriella439
Copy link
Contributor

@thebritican: I just pushed some changes which should fix the CI failures and upgrade dhall to version 1.27.0

@Gabriella439 Gabriella439 merged commit 7af2ab5 into dhall-lang:master Nov 24, 2019
@ari-becker
Copy link
Collaborator

Can we get a new release cut for dhall-kubernetes now that the Schema::{} syntax is the recommended means of using the repo?

@Gabriella439
Copy link
Contributor

@ari-becker: I'm not sure what the release process is for dhall-kubernetes is. Is it just a matter of creating a tag and a GitHub release?

@ari-becker
Copy link
Collaborator

@Gabriel439 yup, pretty sure that's it. Internally we're pinning to specific commits by importing https://raw.githubusercontent.com/dhall-lang/dhall-kubernetes/7af2ab5345fbd09e02437b3a6ce8f10d9e941f4c/schemas.dhall but obviously that's not as semantically meaningful as pinning to a version.

Ping @f-f who released 1.0.0

Related to #57

@gregziegan gregziegan deleted the gziegan/use-schemas-for-examples branch November 25, 2019 16:52
@Gabriella439
Copy link
Contributor

@ari-becker: Alright, I just created a release: https://github.com/dhall-lang/dhall-kubernetes/releases/tag/v2.0.0

@f-f
Copy link
Member

f-f commented Nov 30, 2019

Sorry for delay; yes, a release is just a matter of creating a GitHub release here.

Thanks @Gabriel439 🙂

@Gabriella439
Copy link
Contributor

@f-f: You're welcome! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants