Conversation
…og dialog SettingsScreen now opens SyncErrorLogDialog directly instead of routing through SyncManagerPresenter's checkSyncErrors()/errorLogChannel and the legacy Java ErrorDialog, which the fragment no longer references. SyncManagerModule's provideGetSyncErrors provider becomes dead code here, removed along with GetSyncErrors/ErrorModelMapper's legacy paths next. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Balcan
added this pull request to stack #5174
September 18, 2026 13:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…og dialog
SettingsScreen now opens SyncErrorLogDialog directly instead of routing through SyncManagerPresenter's checkSyncErrors()/errorLogChannel and the legacy Java ErrorDialog, which the fragment no longer references. SyncManagerModule's provideGetSyncErrors provider becomes dead code here, removed along with GetSyncErrors/ErrorModelMapper's legacy paths next.
Description
Link the JIRA issue.
Please provide a clear definition of the problem and explain your solution.