fix: avoid ERROR log when safeInvoke falls back to interface method [DHIS2-22114] (2.43) - #25285
Merged
Merged
Conversation
…DHIS2-22114] (#25220) * fix: avoid ERROR log when safeInvoke falls back to interface method [DHIS2-22114] * fix: Guard null method in safeInvoke precheck [DHIS2-22114] ReflectionUtils.invokeMethod returns null for a null Method, so safeInvoke(object, null) returned null before the instanceof precheck was added. The precheck dereferenced method first and threw an unwrapped NullPointerException. Property.getGetterMethod() is null for a @JsonProperty field without a getter, and several callers pass it straight through. Check method for null before the precheck and pin the contract with a test. --------- Co-authored-by: Morten Svanaes <msvanaes@dhis2.org> (cherry picked from commit 7153c01)
|
netroms
enabled auto-merge (squash)
September 19, 2026 14:54
vietnguyen24
approved these changes
Sep 20, 2026
vietnguyen
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #25220 to 2.43.
Jira: https://dhis2.atlassian.net/browse/DHIS2-22114
Stops
GET /api/dimensions/{uid}/itemsfrom logging an ERROR stack trace whensafeInvokefalls back to the interface method (DHIS2-20730). Cherry-pick of 7153c01 includes the null-Method guard from that squash. Clean apply, no conflicts.Verification:
DefaultSchemaServiceSafeInvokeTest7/7 pass on Java 17;testInterfaceFallbackDoesNotInvokeBaseMethodfails pre-fix withNeverWantedButInvoked. Targeted Spotless passed.AI Assisted