-
Notifications
You must be signed in to change notification settings - Fork 175
Fix and add favorite unit test #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexzPurewoko
wants to merge
21
commits into
master
Choose a base branch
from
update/room-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c379df5
[kotlin][10-room-test] Adding test favorite
AlexzPurewoko 2b7785c
[java][10-room-test] add favorite testing
AlexzPurewoko fa99dae
[java][11-pagination] adding favorite test
AlexzPurewoko f1f2a4a
[kotlin][11-pagination] adding favorite test
AlexzPurewoko 5b54823
[java][12-pagination-test] Adding favorite test
AlexzPurewoko cf3d02c
[kotlin][12-pagination-test] Adding favorite test for some test class
AlexzPurewoko 961d356
[kotlin][12-pagination-test] fix favorite unit test
AlexzPurewoko fb2b596
[java][10-room-test] Adding favorite test
AlexzPurewoko b141372
[java][11-pagination] Adding favorite test
AlexzPurewoko 62954b3
[kotlin][11-pagination] Adding favorite test
AlexzPurewoko 0ad9876
[java][12-pagination-test] Adding favorite test
AlexzPurewoko 0099657
[kotlin][12-pagination-test] Adding favorite test
AlexzPurewoko 91dad10
[kotlin][12-pagination-test] fix favorite unit test
AlexzPurewoko 1d2374d
Merge remote-tracking branch 'origin/update/room-test' into update/ro…
AlexzPurewoko a7e6586
[kotlin][10-room-test] rename field 'exercutor' to 'executor'
AlexzPurewoko d2edebb
[java][10-room-test] fix uneffective code for setBookmark test
AlexzPurewoko 5e8fcba
[kotlin][10-room-test] fix uneffective code for setBookmark test
AlexzPurewoko 0ccbc1d
[java][11-pagination] fix uneffective code for setBookmark test
AlexzPurewoko 076ef28
[kotlin][11-pagination] fix uneffective code for setBookmark test
AlexzPurewoko e208424
[kotlin][12-pagination-test] fix uneffective code for setBookmark test
AlexzPurewoko bb80b06
[java][12-pagination-test] fix uneffective code for setBookmark test
AlexzPurewoko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
...ademy/10. Room-test/java/app/src/test/java/com/dicoding/academies/utils/TestExecutor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package com.dicoding.academies.utils; | ||
|
|
||
| import java.util.concurrent.Executor; | ||
|
|
||
| public class TestExecutor implements Executor { | ||
| @Override | ||
| public void execute(Runnable command) { | ||
| command.run(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
...demy/11. Pagination/java/app/src/test/java/com/dicoding/academies/utils/TestExecutor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package com.dicoding.academies.utils; | ||
|
|
||
| import java.util.concurrent.Executor; | ||
|
|
||
| public class TestExecutor implements Executor { | ||
| @Override | ||
| public void execute(Runnable command) { | ||
| command.run(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ini dummy cuman buat invoke sama verify? Tambahkan assertion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kalau yang ini kan yang di test method void dan hanya meneruskan call saja ke repository. Jadi menurutku, disini cukup verify call method saja
https://blog.knoldus.com/unit-testing-void-methods-with-mockito-and-junit/Atau mungkin dari mas Alfian ada cara lain kah ?