Skip to content

CI: Remove use of Ubuntu 20.04 #8613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 4, 2025
Merged

Conversation

tautschnig
Copy link
Collaborator

GitHub will no longer support ubuntu-20.04 runners after 2025-04-15. Use ubuntu-24.04 or ubuntu-latest instead. This implies that we will no longer release pre-built packages for Ubuntu 20.04.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@TGWDB TGWDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Only comment/thought is that we're clearly choosing here to prefer latest and then when things break due to latest moving under us we need to fix. This may be slightly more opaque than pinning to a version and being very intentional about needing to upgrade when that version reaches end-of-life or we choose to upgrade.

@tautschnig
Copy link
Collaborator Author

Only comment/thought is that we're clearly choosing here to prefer latest and then when things break due to latest moving under us we need to fix. This may be slightly more opaque than pinning to a version and being very intentional about needing to upgrade when that version reaches end-of-life or we choose to upgrade.

Yes, I was hoping that for the ones where I've now chosen ubuntu-latest that they are largely independent of whatever versions of software the OS provides. This may, as you say, turn out to be false. It's a bit of a gamble with the hope that this will reduce future maintenance burden.

@TGWDB
Copy link
Contributor

TGWDB commented Apr 2, 2025

Yes, I was hoping that for the ones where I've now chosen ubuntu-latest that they are largely independent of whatever versions of software the OS provides. This may, as you say, turn out to be false. It's a bit of a gamble with the hope that this will reduce future maintenance burden.

As long as we're aware that we made a choice I don't see there being a big concern. 👍

It would still fail on older platforms, hence marking it `FUTURE` rather
than `CORE` or `KNOWNBUG`.
@tautschnig tautschnig force-pushed the no-20.04 branch 2 times, most recently from 8433e7d to 32f2908 Compare April 3, 2025 08:56
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.37%. Comparing base (fab6710) to head (32d6835).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8613      +/-   ##
===========================================
+ Coverage    79.63%   80.37%   +0.74%     
===========================================
  Files         1733     1686      -47     
  Lines       197820   206770    +8950     
  Branches     17968       85   -17883     
===========================================
+ Hits        157536   166197    +8661     
- Misses       40284    40573     +289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

We cannot compile Linux 5.10 with toolchains involving GCC 12 or newer
without these patches.
More recent versions of iwyu identified new unused headers. (But
struggled to cope with `class C { ... } c;` so that was rewritten as
`class C { ... }; C c;`.)
GitHub will no longer support ubuntu-20.04 runners after 2025-04-15. Use
ubuntu-24.04 or ubuntu-latest instead. This implies that we will no
longer release pre-built packages for Ubuntu 20.04.
iwyu uses clang itself, so is only compatible with compiler command line
options that clang takes rather than GCC's.
@tautschnig tautschnig merged commit 41e9f3d into diffblue:develop Apr 4, 2025
40 checks passed
@tautschnig tautschnig deleted the no-20.04 branch April 4, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants