-
Notifications
You must be signed in to change notification settings - Fork 273
CI: Remove use of Ubuntu 20.04 #8613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
Only comment/thought is that we're clearly choosing here to prefer latest
and then when things break due to latest
moving under us we need to fix. This may be slightly more opaque than pinning to a version and being very intentional about needing to upgrade when that version reaches end-of-life or we choose to upgrade.
Yes, I was hoping that for the ones where I've now chosen |
As long as we're aware that we made a choice I don't see there being a big concern. 👍 |
It would still fail on older platforms, hence marking it `FUTURE` rather than `CORE` or `KNOWNBUG`.
8433e7d
to
32f2908
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8613 +/- ##
===========================================
+ Coverage 79.63% 80.37% +0.74%
===========================================
Files 1733 1686 -47
Lines 197820 206770 +8950
Branches 17968 85 -17883
===========================================
+ Hits 157536 166197 +8661
- Misses 40284 40573 +289 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We cannot compile Linux 5.10 with toolchains involving GCC 12 or newer without these patches.
More recent versions of iwyu identified new unused headers. (But struggled to cope with `class C { ... } c;` so that was rewritten as `class C { ... }; C c;`.)
GitHub will no longer support ubuntu-20.04 runners after 2025-04-15. Use ubuntu-24.04 or ubuntu-latest instead. This implies that we will no longer release pre-built packages for Ubuntu 20.04.
iwyu uses clang itself, so is only compatible with compiler command line options that clang takes rather than GCC's.
GitHub will no longer support ubuntu-20.04 runners after 2025-04-15. Use ubuntu-24.04 or ubuntu-latest instead. This implies that we will no longer release pre-built packages for Ubuntu 20.04.