-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md for android kotlin callouts #2438
Conversation
Seems we can call out spotless/plugin-gradle/README.md Lines 210 to 216 in 34b8ef8
as well. |
Yeah I copied the code from there, but I suppose we can add a warning around it so that github md gives it that nice treatment. Also... does anyone know if both
are needed? I'm assuming so... but idk. |
Yeah, need to add both |
Cool. FWIW. I thought I started which also led me to comment here All related to this readme PR 😄 If anyone can tell where I'm going wrong I'd appreciate it! |
In your comments above...
But the real root of the problem is that each call to |
Thank you for the additional fixes! Every time I add spotless to a project I'm always looking at different notes. Good to have an updated canonical example. Cheers @nedtwigg ! Next step... getting spotless to understand where the android src sets are automatically 🚂 |
Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.
Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.
After creating the PR, please add a commit that adds a bullet-point under the
[Unreleased]
section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
plugin-foo/CHANGES.md
for that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.md
for both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)