Apply Gradle's strict plugin types validation to the Spotless plugin in preparation for Gradle 9.0 #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable Gradle Plugin types strict validation by the :gradle-plugin:validatePlugins task. The task now applies more rules for plugin types. Add missing mandatory cacheability annotations on SpotlessTask, SpotlessApply, SpotlessCheck and SpotlessDiagnoseTask.
eskatos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Gradle Plugin types strict validation by the :gradle-plugin:validatePlugins task.
ValidatePluginschecks property annotations on work items like tasks and artifact transforms. Stricter validation adds forward-moving rules that will be promoted to regular validation. Most often in the next Gradle major version. With Gradle 9.0 coming soon, it's time to move forward. Having a release of the stopless plugin with these fixes before Gradle 9.0 will ensure a smooth transition for users.This commit adds the missing mandatory cacheability annotations reported by the stricter rules on SpotlessTask, SpotlessApply, SpotlessCheck and SpotlessDiagnoseTask.