Can be replaced with String.repeat()

[Pankraz76]

Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.

Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.

After creating the PR, please add a commit that adds a bullet-point under the [Unreleased] section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:

• a summary of the change
• either
  • a link to the issue you are resolving (for small changes)
  • a link to the PR you just created (for big changes likely to have discussion)

If your change only affects a build plugin, and not the lib, then you only need to update the plugin-foo/CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

This makes it easier for the maintainers to quickly release your changes :)

[Pankraz76]

seems flaky:

karoundsTest > Worktrees perWorktreeConfig() PASSED
com.diffplug.spotless.extra.cpp.EclipseCdtFormatterStepTest > formatWithVersion(String) [1] 11.0 PASSED (13.1s)
com.diffplug.spotless.extra.cpp.EclipseCdtFormatterStepTest > formatWithVersion(String) [2] 11.6 FAILED (5.1s)

  com.diffplug.spotless.ThrowingEx$WrappedAsRuntimeException: java.io.IOException: Failed to load eclipse cdt formatter: java.lang.IllegalStateException: P2 operation already in progress, close other clients or delete stale lockfile at C:Usersrunneradmin.m2repositorydevequop2-datametadata.lock
      at app//com.diffplug.spotless.extra.cpp.EclipseCdtFormatterStepTest.formatWithVersion(EclipseCdtFormatterStepTest.java:34)
  Caused by: java.io.IOException: Failed to load eclipse cdt formatter: java.lang.IllegalStateException: P2 operation already in progress, close other clients or delete stale lockfile at C:Usersrunneradmin.m2repositorydevequop2-datametadata.lock
      at com.diffplug.spotless.extra.cpp.EclipseCdtFormatterStepTest.formatWithVersion(EclipseCdtFormatterStepTest.java:34)
  Caused by: java.lang.IllegalStateException: P2 operation already in progress, close other clients or delete stale lockfile at C:Usersrunneradmin.m2repositorydevequop2-datametadata.lock
      at com.diffplug.spotless.extra.cpp.EclipseCdtFormatterStepTest.formatWithVersion(EclipseCdtFormatterStepTest.java:34)
[/[]

> Task :plugin-gradle:test

[nedtwigg]

This seems to have some duplication with the other open PR. I need a break from reviewing these for a little while, see #2702 (comment)

[Pankraz76]

yes its a little too much, im sorry for that.

Never the less thank you very much for the great journey so far.