Skip to content

Add comment for RuntimeWarning surpression #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbillinge merged 7 commits into from
Oct 30, 2024
Merged

Add comment for RuntimeWarning surpression #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3b29867
add comment
cadenmyers13 Oct 30, 2024
d371bfe
edit to news item
cadenmyers13 Oct 30, 2024
4b551bc
add comment to other test
cadenmyers13 Oct 30, 2024
74e1401
small tweak to comments by simon
sbillinge Oct 30, 2024
94d0089
[pre-commit.ci] auto fixes from pre-commit hooks
pre-commit-ci[bot] Oct 30, 2024
f1d2c22
pre-commit fixes
sbillinge Oct 30, 2024
46765cd
[pre-commit.ci] auto fixes from pre-commit hooks
pre-commit-ci[bot] Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion news/test.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

**Fixed:**

* Surpress `RuntimeWarning` in tests for the `applycutoff` function
* Surpress the `RuntimeWarning` in tests for the `applycutoff` function

**Security:**

Expand Down
10 changes: 8 additions & 2 deletions tests/integration_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,12 @@ def test_applycutoff_range1(self):
self.test_gui.qminentry.insert(0, "10")
self.test_gui.qmaxentry.insert(0, "40")

# when
# Desired behavior is nans in the arrays below qmin and above qmax. As a result, np.nanmax will generate
# runtimewarnings when it # encounters slices that are all nans. capture these so tests pass cleanly
# without warnings
with warnings.catch_warnings():
warnings.simplefilter("ignore", category=RuntimeWarning)
# when
self.test_gui.applycutoff()
result = self.test_gui.cube

Expand All @@ -121,9 +124,12 @@ def test_applycutoff_range2(self):
self.test_gui.qminentry.insert(0, "15")
self.test_gui.qmaxentry.insert(0, "35")

# when
# Desired behavior is nans in the arrays below qmin and above qmax. As a result, np.nanmax will generate
# runtimewarnings when it # encounters slices that are all nans. capture these so tests pass cleanly
# without warnings
with warnings.catch_warnings():
warnings.simplefilter("ignore", category=RuntimeWarning)
# when
self.test_gui.applycutoff()
result = self.test_gui.cube

Expand Down