feat: make muD optional and have different options for specifying muD #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 99.20% 99.19% -0.02%
==========================================
Files 5 5
Lines 253 249 -4
==========================================
- Hits 251 247 -4
Misses 2 2
🚀 New features to boost your workflow:
|
|
Screenshots of the cli and gui interfaces: |
yucongalicechen
commented
Feb 24, 2025
| ] | ||
| return args | ||
|
|
||
|
|
||
| def _add_mud_selection_group(p, is_gui=False): | ||
| """Current Options: |
There was a problem hiding this comment.
grouped the related mu*D arguments
yucongalicechen
commented
Feb 24, 2025
| ) | ||
| args.z_scan_file = str(filepath) | ||
| args.mud = compute_mud(filepath) | ||
| return _estimate_mud_from_zscan(args) |
There was a problem hiding this comment.
Made the z-scan part a separate private function
yucongalicechen
commented
Feb 24, 2025
| @@ -113,7 +113,7 @@ def test_set_input_lists(inputs, expected, user_filesystem): | |||
| base_dir.resolve() / expected_path for expected_path in expected | |||
| ] | |||
|
|
|||
| cli_inputs = ["2.5"] + inputs | |||
| cli_inputs = inputs + ["--mud", "2.5"] | |||
There was a problem hiding this comment.
Manually entered muD following the new convention ("2.5" to "--mud", "2.5")
yucongalicechen
commented
Feb 24, 2025
| assert actual_args.mud == pytest.approx(2.5, rel=1e-4, abs=0.1) | ||
| assert actual_args.z_scan_file is None | ||
|
|
||
| @pytest.mark.parametrize( |
|
@sbillinge could you check this PR too when you get a chance? Thanks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sbillinge ready for review