Skip to content

Actual firestore behavior to return none not {} #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaitreyaBuddha wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Actual firestore behavior to return none not {} #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mockfirestore/document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ def exists(self) -> bool:
return self._doc != {}

def to_dict(self) -> Document:
if not self.exists:
return None
return self._doc

@property
Expand Down
2 changes: 1 addition & 1 deletion tests/test_document_reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def test_document_get_documentDoesNotExist(self):
fs = MockFirestore()
fs._data = {'foo': {}}
doc = fs.collection('foo').document('bar').get().to_dict()
self.assertEqual({}, doc)
self.assertIsNone(doc)

def test_get_nestedDocument(self):
fs = MockFirestore()
Expand Down
Loading