Add support for @direction.
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 75.93% 76.17% +0.24%
==========================================
Files 10 10
Lines 590 596 +6
==========================================
+ Hits 448 454 +6
Misses 142 142
Continue to review full report in Codecov by Sentry.
|
dlongley
requested changes
Nov 22, 2024
There was a problem hiding this comment.
We also need to update:
https://github.com/digitalbazaar/di-sd-primitives/blob/v3.0.4/lib/skolemize.js#L104-L105
Also the rdfDirection option should probably be done before ...options to allow the caller to override if they want to (in all the places).
dlongley
reviewed
Nov 22, 2024
lib/canonicalize.js
Outdated
Comment on lines
67
to
68
| const opts = { | ||
| ...options, produceGeneralizedRdf: false, rdfDirection: 'i18n-datatype' |
There was a problem hiding this comment.
Suggested change
| const opts = { | |
| ...options, produceGeneralizedRdf: false, rdfDirection: 'i18n-datatype' | |
| const opts = { | |
| rdfDirection: 'i18n-datatype', ...options, produceGeneralizedRdf: false |
dlongley
reviewed
Nov 22, 2024
lib/canonicalize.js
Outdated
| const opts = {...options, produceGeneralizedRdf: false}; | ||
| const opts = { | ||
| ...options, produceGeneralizedRdf: false, rdfDirection: 'i18n-datatype' | ||
| }; | ||
| delete opts.format; | ||
| opts.produceGeneralizedRdf = false; |
There was a problem hiding this comment.
Suggested change
| opts.produceGeneralizedRdf = false; |
dlongley
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.