Support for "@import".
#352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlehn
reviewed
Jan 26, 2020
davidlehn
reviewed
Jan 26, 2020
| {code: 'invalid remote context', context: localCtx}); | ||
| } | ||
| const importCtx = resolvedImport[0].document; | ||
| if('@import' in importCtx) { |
There was a problem hiding this comment.
Seems like this would need to be more involved to catch @import in scoped contexts too. There are not test for this.
There was a problem hiding this comment.
Catching it was going to require adding more state to be passed down, and even though it isn't the use case, it doesn't really cause any harm if its (mis)used this way. But, that would be an issue on the spec.
Co-Authored-By: David I. Lehn <[email protected]>
|
Does look like maybe a caching issue could happen. I'm not sure what the situation is or if it's worth dealing with. Maybe if you use the same resources as a context and also as an import? Let's leave that alone until someone can figure out a test case. |
davidlehn
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might not be playing nicely with caching, please consider.