Skip to content

Handle term definition on @type with empty map. #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Conversation

davidlehn
Copy link
Member

Fixes expand#tec02 & toRdf#tec02.

@gkellogg "keyword redefinition" was not what I expected for this type of error. Is that more appropriate than the more generic "invalid term definition"?

Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I agree with @davidlehn that this should be an invalid term definition error.

@davidlehn davidlehn added this to the JSON-LD 1.1 milestone Feb 27, 2020
@davidlehn davidlehn added the bug label Feb 27, 2020
@gkellogg
Copy link
Collaborator

Fixes expand#tec02 & toRdf#tec02.

@gkellogg "keyword redefinition" was not what I expected for this type of error. Is that more appropriate than the more generic "invalid term definition"?

It's "keyword redefinition" as that is the case for any attempt to change a keyword, other than specific carve-outs for @type. One could argue for "invalid term definition", but it's not a term, and it's a bit late to change the spec.

@davidlehn davidlehn merged commit 6d7a453 into master Feb 27, 2020
@davidlehn davidlehn deleted the type-empty-map branch February 27, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants