Fix term mapping of @reverse.
#370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "ignore" behavior is important, as it affects processing flow. You should also generate a warning. The bug I had in my code was I checked after expanding it as an IRI, which led to a failure, which is not right. With the ignore/warning, you drop out of the create term definition for that term and a term doesn't get created. |
gkellogg
requested changes
Feb 27, 2020
davidlehn
force-pushed
the
reverse-handling
branch
from
a575246 to
c9a0940
Compare
davidlehn
force-pushed
the
reverse-handling
branch
from
c9a0940 to
d7c4e4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check. I'm making tests pass without proper understanding of how this should be working. Should there be some warning here or is the "ignore" behavior itself important?