[Nova 4] restores Tailwind styles #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@dillingham could you perhaps take a look at this one and tag a release if you agree? Thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something changed in Nova 4 that breaks a lot of Tailwind classes. Basically, any class that is not used somewhere in Nova v4 won't be available inside 3rd party fields, cards, tools, etc.
It's explained in laravel/nova-issues#4061 (comment).
Fixing this involves adding tailwind to the package and using a way of "scoping" the field with a custom class.
Jess Archer's tweet here helped with the solution: https://twitter.com/jessarchercodes/status/1515139491794599939?
I've made the changes below. But for some reason I am having difficulty building the dist files because of the way you link to
laravel-novainsidemix.jsYou should be able to build the dist files and then test that the Tailwind styles are back to working like they were before.
Cheers!