update to eslint 9 (#2452)

* chore(deps): update dependency eslint to v9 * upd * upd * upd * more * more * more * more * prettier * fix type check * fix type check * fix type check * fix type check * fix bob check * more work * pnpm i * fix prebuild * Update website/src/components/graphql-editor.tsx * fix types error --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
dimaMachina · Jul 31, 2024 · 7e23fa4 · 7e23fa4
1 parent 277ead9
commit 7e23fa4
Show file tree

Hide file tree

Showing 86 changed files with 494 additions and 417 deletions.
diff --git a/.changeset/real-coins-share.md b/.changeset/real-coins-share.md
@@ -1,5 +1,5 @@
 ---
-"@graphql-eslint/eslint-plugin": major
+'@graphql-eslint/eslint-plugin': major
 ---
 
 exposing GraphQLESTreeNode type
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -51,6 +51,7 @@ module.exports = {
       extends: ['plugin:eslint-plugin/tests-recommended'],
       rules: {
         'eslint-plugin/test-case-shorthand-strings': 'error',
+        'import/extensions': 'off',
       },
     },
     {

diff --git a/examples/code-file/package.json b/examples/code-file/package.json
@@ -12,8 +12,8 @@
     "graphql": "16.9.0"
   },
   "devDependencies": {
-    "@eslint/js": "9.2.0",
+    "@eslint/js": "9.8.0",
     "@graphql-eslint/eslint-plugin": "workspace:*",
-    "eslint": "8.57.0"
+    "eslint": "9.8.0"
   }
 }
diff --git a/examples/graphql-config/package.json b/examples/graphql-config/package.json
@@ -12,8 +12,8 @@
     "graphql": "16.9.0"
   },
   "devDependencies": {
-    "@eslint/js": "9.2.0",
+    "@eslint/js": "9.8.0",
     "@graphql-eslint/eslint-plugin": "workspace:*",
-    "eslint": "8.57.0"
+    "eslint": "9.8.0"
   }
 }
diff --git a/examples/monorepo/package.json b/examples/monorepo/package.json
@@ -11,8 +11,8 @@
     "graphql": "16.9.0"
   },
   "devDependencies": {
-    "@eslint/js": "9.2.0",
+    "@eslint/js": "9.8.0",
     "@graphql-eslint/eslint-plugin": "workspace:*",
-    "eslint": "8.57.0"
+    "eslint": "9.8.0"
   }
 }
diff --git a/examples/multiple-projects-graphql-config/package.json b/examples/multiple-projects-graphql-config/package.json
@@ -4,13 +4,13 @@
   "author": "Dimitri POSTOLOV",
   "private": true,
   "scripts": {
-    "lint": "eslint ."
+    "lint": "ESLINT_USE_FLAT_CONFIG=false eslint ."
   },
   "dependencies": {
     "graphql": "16.9.0"
   },
   "devDependencies": {
     "@graphql-eslint/eslint-plugin": "workspace:*",
-    "eslint": "8.57.0"
+    "eslint": "9.8.0"
   }
 }
diff --git a/examples/prettier/package.json b/examples/prettier/package.json
@@ -12,9 +12,9 @@
     "graphql": "16.9.0"
   },
   "devDependencies": {
-    "@eslint/js": "9.2.0",
+    "@eslint/js": "9.8.0",
     "@graphql-eslint/eslint-plugin": "workspace:*",
-    "eslint": "8.57.0",
+    "eslint": "9.8.0",
     "eslint-config-prettier": "9.1.0",
     "eslint-plugin-prettier": "5.2.1",
     "prettier": "3.3.3"

diff --git a/examples/programmatic/package.json b/examples/programmatic/package.json
@@ -12,8 +12,8 @@
     "graphql": "16.9.0"
   },
   "devDependencies": {
-    "@eslint/js": "9.2.0",
+    "@eslint/js": "9.8.0",
     "@graphql-eslint/eslint-plugin": "workspace:*",
-    "eslint": "8.57.0"
+    "eslint": "9.8.0"
   }
 }
diff --git a/examples/svelte-code-file/package.json b/examples/svelte-code-file/package.json
@@ -5,14 +5,14 @@
   "author": "Dimitri POSTOLOV",
   "private": true,
   "scripts": {
-    "lint": "eslint ."
+    "lint": "ESLINT_USE_FLAT_CONFIG=false eslint ."
   },
   "dependencies": {
     "graphql": "16.9.0"
   },
   "devDependencies": {
     "@graphql-eslint/eslint-plugin": "workspace:*",
-    "eslint": "8.57.0",
+    "eslint": "9.8.0",
     "svelte": "4.2.18",
     "svelte-eslint-parser": "0.41.0",
     "svelte2tsx": "0.7.15"

diff --git a/examples/vue-code-file/package.json b/examples/vue-code-file/package.json
@@ -5,15 +5,15 @@
   "author": "Dimitri POSTOLOV",
   "private": true,
   "scripts": {
-    "lint": "eslint ."
+    "lint": "ESLINT_USE_FLAT_CONFIG=false eslint ."
   },
   "dependencies": {
     "graphql": "16.9.0"
   },
   "devDependencies": {
     "@graphql-eslint/eslint-plugin": "workspace:*",
     "@vue/compiler-sfc": "3.4.35",
-    "eslint": "8.57.0",
+    "eslint": "9.8.0",
     "vue-eslint-parser": "9.4.3"
   }
 }
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
-  "type": "module",
   "name": "graphql-eslint-monorepo",
+  "type": "module",
   "repository": "https://github.com/B2o5T/graphql-eslint",
   "author": "Dotan Simha <[email protected]>",
   "license": "MIT",
@@ -12,10 +12,10 @@
   },
   "scripts": {
     "build": "turbo run build --filter=!website && bob check",
-    "ci:lint": "eslint --ignore-path .gitignore --output-file eslint_report.json --format json .",
+    "ci:lint": "ESLINT_USE_FLAT_CONFIG=false eslint --ignore-path .gitignore --output-file eslint_report.json --format json .",
     "create-rule": "tsx scripts/create-rule.ts",
     "generate:configs": "tsx scripts/generate-configs.ts",
-    "lint": "eslint --ignore-path .gitignore --cache .",
+    "lint": "ESLINT_USE_FLAT_CONFIG=false eslint --ignore-path .gitignore --cache .",
     "lint:prettier": "prettier --ignore-path .gitignore --ignore-path .prettierignore --cache --check .",
     "prebuild": "rimraf tsconfig.tsbuildinfo",
     "prerelease": "NODE_ENV=production pnpm build",
@@ -36,7 +36,7 @@
     "chalk": "5.3.0",
     "dedent": "1.5.3",
     "enquirer": "2.4.1",
-    "eslint": "8.57.0",
+    "eslint": "9.8.0",
     "eslint-plugin-eslint-plugin": "6.2.0",
     "eslint-plugin-tailwindcss": "3.17.4",
     "husky": "9.1.4",
@@ -53,7 +53,7 @@
   },
   "pnpm": {
     "patchedDependencies": {
-      "eslint@8.48.0": "patches/[email protected]",
+      "eslint@9.8.0": "patches/[email protected]",
       "[email protected]": "patches/[email protected]"
     }
   }

diff --git a/packages/plugin/__tests__/alphabetize.spec.ts b/packages/plugin/__tests__/alphabetize.spec.ts
@@ -1,5 +1,5 @@
-import { rule, RuleOptions } from '../src/rules/alphabetize';
-import { ruleTester } from './test-utils';
+import { rule, RuleOptions } from '../src/rules/alphabetize.js';
+import { ruleTester } from './test-utils.js';
 
 const GROUP_ORDER_TEST = /* GraphQL */ `
   type User {

diff --git a/packages/plugin/__tests__/description-style.spec.ts b/packages/plugin/__tests__/description-style.spec.ts
@@ -1,5 +1,5 @@
-import { rule, RuleOptions } from '../src/rules/description-style';
-import { ruleTester } from './test-utils';
+import { rule, RuleOptions } from '../src/rules/description-style.js';
+import { ruleTester } from './test-utils.js';
 
 const INLINE_SDL = /* GraphQL */ `
   " Test "

diff --git a/packages/plugin/__tests__/eslint-directives.spec.ts b/packages/plugin/__tests__/eslint-directives.spec.ts
@@ -1,7 +1,7 @@
 import { join } from 'node:path';
-import { rule as noAnonymousOperations } from '../src/rules/no-anonymous-operations';
-import { rule as noTypenamePrefix } from '../src/rules/no-typename-prefix';
-import { ruleTester } from './test-utils';
+import { rule as noAnonymousOperations } from '../src/rules/no-anonymous-operations.js';
+import { rule as noTypenamePrefix } from '../src/rules/no-typename-prefix.js';
+import { ruleTester } from './test-utils.js';
 
 ruleTester.run('no-typename-prefix', noTypenamePrefix, {
   valid: [
@@ -10,7 +10,7 @@ ruleTester.run('no-typename-prefix', noTypenamePrefix, {
       code: /* GraphQL */ `
         type Type {
           "Some description"
-          typeName: String! # eslint-disable-line no-typename-prefix
+          typeName: String! # eslint-disable-line rule-to-test/no-typename-prefix
         }
       `,
     },
@@ -27,12 +27,12 @@ ruleTester.run('test-directives', noAnonymousOperations, {
       }
     `,
     /* GraphQL */ `
-      # eslint-disable-next-line test-directives
+      # eslint-disable-next-line rule-to-test/test-directives
       {
         a
       }
     `,
-    '{ a } # eslint-disable-line test-directives',
+    '{ a } # eslint-disable-line rule-to-test/test-directives',
     '{ a } # eslint-disable-line',
     /* GraphQL */ `
       # eslint-disable

diff --git a/packages/plugin/__tests__/examples.spec.ts b/packages/plugin/__tests__/examples.spec.ts
@@ -1,7 +1,7 @@
 import { spawnSync } from 'node:child_process';
 import { join, relative } from 'node:path';
 import { ESLint } from 'eslint';
-import { CWD as PROJECT_CWD } from '../src/utils';
+import { CWD as PROJECT_CWD } from '../src/utils.js';
 
 const CWD = join(PROJECT_CWD, '..', '..');
 

diff --git a/packages/plugin/__tests__/executable-definitions.spec.ts b/packages/plugin/__tests__/executable-definitions.spec.ts
@@ -1,5 +1,5 @@
-import { GRAPHQL_JS_VALIDATIONS } from '../src/rules/graphql-js-validation';
-import { ParserOptionsForTests, ruleTester } from './test-utils';
+import { GRAPHQL_JS_VALIDATIONS } from '../src/rules/graphql-js-validation.js';
+import { ParserOptionsForTests, ruleTester } from './test-utils.js';
 
 const TEST_SCHEMA = /* GraphQL */ `
   type Query {

diff --git a/packages/plugin/__tests__/fields-on-correct-type.spec.ts b/packages/plugin/__tests__/fields-on-correct-type.spec.ts
@@ -1,22 +1,23 @@
-// @ts-expect-error -- add `"type": "module"` to `package.json` to fix this
 import { RuleTester } from '@theguild/eslint-rule-tester';
-import { GRAPHQL_JS_VALIDATIONS } from '../src/rules/graphql-js-validation';
-import { DEFAULT_CONFIG, ParserOptionsForTests } from './test-utils';
+import { GRAPHQL_JS_VALIDATIONS } from '../src/rules/graphql-js-validation.js';
+import { DEFAULT_CONFIG, ParserOptionsForTests } from './test-utils.js';
 
 const ruleTester = new RuleTester<ParserOptionsForTests>({
-  ...DEFAULT_CONFIG,
-  parserOptions: {
-    graphQLConfig: {
-      schema: /* GraphQL */ `
-        type User {
-          id: ID
-          age: Int
-        }
+  languageOptions: {
+    ...DEFAULT_CONFIG.languageOptions,
+    parserOptions: {
+      graphQLConfig: {
+        schema: /* GraphQL */ `
+          type User {
+            id: ID
+            age: Int
+          }
 
-        type Query {
-          user: User
-        }
-      `,
+          type Query {
+            user: User
+          }
+        `,
+      },
     },
   },
 });

diff --git a/packages/plugin/__tests__/input-name.spec.ts b/packages/plugin/__tests__/input-name.spec.ts
@@ -1,5 +1,5 @@
-import { rule, RuleOptions } from '../src/rules/input-name';
-import { ruleTester } from './test-utils';
+import { rule, RuleOptions } from '../src/rules/input-name.js';
+import { ruleTester } from './test-utils.js';
 
 ruleTester.run<RuleOptions>('input-name', rule, {
   valid: [

diff --git a/packages/plugin/__tests__/known-directives.spec.ts b/packages/plugin/__tests__/known-directives.spec.ts
@@ -1,21 +1,22 @@
-// @ts-expect-error -- add `"type": "module"` to `package.json` to fix this
 import { RuleTester } from '@theguild/eslint-rule-tester';
-import { GRAPHQL_JS_VALIDATIONS } from '../src/rules/graphql-js-validation';
-import { DEFAULT_CONFIG, ParserOptionsForTests } from './test-utils';
+import { GRAPHQL_JS_VALIDATIONS } from '../src/rules/graphql-js-validation.js';
+import { DEFAULT_CONFIG, ParserOptionsForTests } from './test-utils.js';
 
 const ruleTester = new RuleTester<ParserOptionsForTests>({
-  ...DEFAULT_CONFIG,
-  parserOptions: {
-    graphQLConfig: {
-      schema: /* GraphQL */ `
-        type User {
-          id: ID!
-        }
+  languageOptions: {
+    ...DEFAULT_CONFIG.languageOptions,
+    parserOptions: {
+      graphQLConfig: {
+        schema: /* GraphQL */ `
+          type User {
+            id: ID!
+          }
 
-        type Query {
-          user: User
-        }
-      `,
+          type Query {
+            user: User
+          }
+        `,
+      },
     },
   },
 });

diff --git a/packages/plugin/__tests__/known-fragment-names.spec.ts b/packages/plugin/__tests__/known-fragment-names.spec.ts
@@ -1,6 +1,6 @@
 import { join } from 'node:path';
-import { GRAPHQL_JS_VALIDATIONS } from '../src/rules/graphql-js-validation';
-import { ruleTester } from './test-utils';
+import { GRAPHQL_JS_VALIDATIONS } from '../src/rules/graphql-js-validation.js';
+import { ruleTester } from './test-utils.js';
 
 ruleTester.run('known-fragment-names', GRAPHQL_JS_VALIDATIONS['known-fragment-names'], {
   valid: [

diff --git a/packages/plugin/__tests__/lone-executable-definition.spec.ts b/packages/plugin/__tests__/lone-executable-definition.spec.ts
@@ -1,5 +1,5 @@
-import { rule, RuleOptions } from '../src/rules/lone-executable-definition';
-import { ruleTester } from './test-utils';
+import { rule, RuleOptions } from '../src/rules/lone-executable-definition.js';
+import { ruleTester } from './test-utils.js';
 
 ruleTester.run<RuleOptions>('lone-executable-definition', rule, {
   valid: [

diff --git a/packages/plugin/__tests__/lone-schema-definition.spec.ts b/packages/plugin/__tests__/lone-schema-definition.spec.ts
@@ -1,5 +1,5 @@
-import { GRAPHQL_JS_VALIDATIONS } from '../src/rules/graphql-js-validation';
-import { ruleTester } from './test-utils';
+import { GRAPHQL_JS_VALIDATIONS } from '../src/rules/graphql-js-validation.js';
+import { ruleTester } from './test-utils.js';
 
 ruleTester.run('lone-schema-definition', GRAPHQL_JS_VALIDATIONS['lone-schema-definition'], {
   valid: [

diff --git a/packages/plugin/__tests__/match-document-filename.spec.ts b/packages/plugin/__tests__/match-document-filename.spec.ts
@@ -1,5 +1,5 @@
-import { rule, RuleOptions } from '../src/rules/match-document-filename';
-import { ruleTester } from './test-utils';
+import { rule, RuleOptions } from '../src/rules/match-document-filename.js';
+import { ruleTester } from './test-utils.js';
 
 ruleTester.run<RuleOptions>('match-document-filename', rule, {
   valid: [

diff --git a/packages/plugin/__tests__/mocks/graphql-server.ts b/packages/plugin/__tests__/mocks/graphql-server.ts
@@ -4,7 +4,6 @@ import { resolve } from 'node:path';
 import { fileURLToPath } from 'node:url';
 import { buildSchema, introspectionFromSchema } from 'graphql';
 
-// @ts-expect-error -- add `"type": "module"` to `package.json` to fix this
 const __dirname = fileURLToPath(new URL('.', import.meta.url));
 
 const sdlSchema = readFileSync(resolve(__dirname, 'user-schema.graphql'), 'utf8');

diff --git a/packages/plugin/__tests__/naming-convention.spec.ts b/packages/plugin/__tests__/naming-convention.spec.ts
@@ -1,5 +1,5 @@
-import { rule, RuleOptions } from '../src/rules/naming-convention';
-import { ruleTester } from './test-utils';
+import { rule, RuleOptions } from '../src/rules/naming-convention.js';
+import { ruleTester } from './test-utils.js';
 
 ruleTester.run<RuleOptions>('naming-convention', rule, {
   valid: [

diff --git a/packages/plugin/__tests__/no-anonymous-operations.spec.ts b/packages/plugin/__tests__/no-anonymous-operations.spec.ts
@@ -1,5 +1,5 @@
-import { rule } from '../src/rules/no-anonymous-operations';
-import { ruleTester } from './test-utils';
+import { rule } from '../src/rules/no-anonymous-operations.js';
+import { ruleTester } from './test-utils.js';
 
 ruleTester.run('no-anonymous-operations', rule, {
   valid: ['query myQuery { a }', 'mutation doSomething { a }', 'subscription myData { a }'],

diff --git a/packages/plugin/__tests__/no-deprecated.spec.ts b/packages/plugin/__tests__/no-deprecated.spec.ts
@@ -1,5 +1,5 @@
-import { rule } from '../src/rules/no-deprecated';
-import { ParserOptionsForTests, ruleTester } from './test-utils';
+import { rule } from '../src/rules/no-deprecated.js';
+import { ParserOptionsForTests, ruleTester } from './test-utils.js';
 
 const TEST_SCHEMA = /* GraphQL */ `
   type Query {

diff --git a/packages/plugin/__tests__/no-duplicate-fields.spec.ts b/packages/plugin/__tests__/no-duplicate-fields.spec.ts
@@ -1,5 +1,5 @@
-import { rule } from '../src/rules/no-duplicate-fields';
-import { ruleTester } from './test-utils';
+import { rule } from '../src/rules/no-duplicate-fields.js';
+import { ruleTester } from './test-utils.js';
 
 ruleTester.run('no-duplicate-fields', rule, {
   valid: [],

diff --git a/packages/plugin/__tests__/no-hashtag-description.spec.ts b/packages/plugin/__tests__/no-hashtag-description.spec.ts
@@ -1,5 +1,5 @@
-import { rule, RULE_ID } from '../src/rules/no-hashtag-description';
-import { ruleTester } from './test-utils';
+import { rule, RULE_ID } from '../src/rules/no-hashtag-description.js';
+import { ruleTester } from './test-utils.js';
 
 ruleTester.run('no-hashtag-description', rule, {
   valid: [