Skip to content

Allow string in scrollToId #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow string in scrollToId #153

wants to merge 3 commits into from

Conversation

safareli
Copy link

NodeId can be string or number but scrollToId only allows number.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.498% when pulling 716dcb9 on safareli:patch-1 into 0a65dfb on diogofcunha:master.

@Strandinator Strandinator mentioned this pull request Sep 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@safareli @coveralls