do not force default features on consumers #8

Niedzwiedzw · 2025-02-13T17:08:13Z

No description provided.

matthunz · 2025-02-13T17:24:41Z

I would love to see cross platform support like this!

Unfortunately this crate still relies on a few dependencies that are still web-only, like dioxus-resize-observer. Using the new JS eval techniques it should be possible to migrate to native platforms

…ed by Cargo book)

Niedzwiedzw · 2025-02-13T17:28:34Z

the problem is that adding this crate to dependencies enables the dioxus logging functionality by default, and I'm rolling my own logger which then panics.

marc2332 · 2025-02-13T17:29:05Z

Just wondering, what specific features of dx are enabled by default that could not be wanted when using this library? It doesn't make sense, the features you disabled are enabled anyway because of the other dx dependencies used here, so it doesn't really change anything

Few things to improve nonetheless:

Ignore the lock in git
use dioxus-lib instead of dioxus

marc2332 · 2025-02-13T17:29:38Z

the problem is that adding this crate to dependencies enables the dioxus logging functionality by default, and I'm rolling my own logger which then panics.

Fair point, but I'd just switch to dioxus-lib then

Niedzwiedzw · 2025-02-13T17:30:54Z

the problem is that adding this crate to dependencies enables the dioxus logging functionality by default, and I'm rolling my own logger which then panics.

Fair point, but I'd just switch to dioxus-lib then

all right let me try...

Niedzwiedzw · 2025-02-13T17:36:32Z

mkay I'm down to 1 error

error[E0599]: no method named `as_web_event` found for reference `&MountedData` in the current scope
  --> src/use_list.rs:86:32
   |
86 |             let elem = mounted.as_web_event();
   |                                ^^^^^^^^^^^^ method not found in `&MountedData`

For more information about this error, try `rustc --explain E0599`.

Niedzwiedzw · 2025-02-13T17:46:59Z

but it doesn't fix the problem because https://github.com/dioxus-community/dioxus-resize-observer/blob/20cd988e9ce13680179d11141220cc4f0474c4c0/Cargo.toml#L10

marc2332 · 2025-02-13T17:51:37Z

it works now?

Niedzwiedzw · 2025-02-13T17:52:34Z

still testing

marc2332 · 2025-02-13T18:03:58Z

Moving dioxus behind a feature won't fix it, we probably also need to change https://github.com/dioxus-community/dioxus-use-mounted/blob/779bda19f6c87125170f8859701ba1df172813ff/Cargo.toml#L10 to dioxus-lib, if you can setup a PR really quick I can merge it and release it

Niedzwiedzw · 2025-02-13T18:04:31Z

ok it's still getting pulled by dioxus-use-mounted - it's very small though, I'll try patching it there as well

Niedzwiedzw · 2025-02-13T18:11:55Z

so once this and dioxus-community/dioxus-use-mounted#6 get merged it should work

marc2332 · 2025-02-13T18:12:54Z

left some comments

marc2332 · 2025-02-13T18:41:24Z

Just released https://crates.io/crates/dioxus-use-mounted @Niedzwiedzw :)

Niedzwiedzw · 2025-02-13T18:44:45Z

Just released https://crates.io/crates/dioxus-use-mounted @Niedzwiedzw :)

Niedzwiedzw · 2025-02-13T18:45:16Z

nothing needs to be done here cause the specified version is 0.3 right?

marc2332 · 2025-02-13T18:47:31Z

nothing needs to be done here cause the specified version is 0.3 right?

Yeah, just make sure to run cargo update so it fetches the latest release

Niedzwiedzw · 2025-02-13T18:48:33Z

all right it officially works on my machine™

marc2332 · 2025-02-13T19:07:24Z

Nice!

Cargo.toml

marc2332 · 2025-02-13T20:12:50Z

README.md

@@ -49,4 +49,3 @@ fn app() -> Element {
        onmounted: move |event| list.mounted.onmounted(event)
    })
 }
-```


Any reason this was removed? seems like an accident

marc2332 · 2025-02-13T20:13:51Z

Cargo.toml


 [dev-dependencies]
-console_error_panic_hook = "0.1.7"
+console_error_panic_hook = "0.1"


Suggested change

console_error_panic_hook = "0.1"

console_error_panic_hook = "0.1"

dioxus = { version = "0.6", features = ["web"] }

marc2332 · 2025-02-13T20:14:01Z

examples/async_list.rs

 use dioxus_lazy::{lazy, List};
+use dioxus_lib::prelude::*;


Suggested change

use dioxus_lib::prelude::*;

use dioxus::prelude::*;

marc2332 · 2025-02-13T20:14:16Z

examples/async_list.rs

@@ -18,5 +18,5 @@ fn main() {
    dioxus_logger::init(Level::INFO).unwrap();
    console_error_panic_hook::set_once();

-    dioxus::launch(app);
+    dioxus_web::launch::launch_cfg(app, dioxus_web::Config::new())


Suggested change

dioxus_web::launch::launch_cfg(app, dioxus_web::Config::new())

launch(app)

marc2332 · 2025-02-13T20:14:23Z

examples/list.rs

 use dioxus_lazy::{lazy, List};
+use dioxus_lib::prelude::*;


Suggested change

use dioxus_lib::prelude::*;

use dioxus::prelude::*;

marc2332 · 2025-02-13T20:14:33Z

examples/list.rs

@@ -17,6 +17,5 @@ fn app() -> Element {
 fn main() {
    dioxus_logger::init(Level::INFO).unwrap();
    console_error_panic_hook::set_once();
-
-    dioxus::launch(app);
+    dioxus_web::launch::launch_cfg(app, dioxus_web::Config::new())


Suggested change

dioxus_web::launch::launch_cfg(app, dioxus_web::Config::new())

launch(app)

marc2332 · 2025-02-13T20:14:41Z

examples/use_list.rs

 use dioxus_lazy::{lazy, Direction, UseList};
+use dioxus_lib::prelude::*;


Suggested change

use dioxus_lib::prelude::*;

use dioxus::prelude::*;

marc2332 · 2025-02-13T20:14:52Z

examples/use_list.rs

@@ -16,6 +16,5 @@ fn app() -> Element {
 fn main() {
    dioxus_logger::init(Level::INFO).unwrap();
    console_error_panic_hook::set_once();
-
-    dioxus::launch(app);
+    dioxus_web::launch::launch_cfg(app, dioxus_web::Config::new())


Suggested change

dioxus_web::launch::launch_cfg(app, dioxus_web::Config::new())

launch(app)

Niedzwiedzw added 2 commits February 13, 2025 18:07

do not force default features on consumers

4d067bc

more liberal version

e37ec7c

Niedzwiedzw force-pushed the main branch from d358e72 to e37ec7c Compare February 13, 2025 17:19

make all versions more liberal, remove Cargo.lock from VSC (recommend…

6cf73dd

…ed by Cargo book)

marc2332 added the enhancement New feature or request label Feb 13, 2025

marc2332 self-requested a review February 13, 2025 17:29

switch to dioxus-lib for all deps

d9ae6e8

remove unused dioxus-resize-observer dependency

e05991b

hide dioxus dependency behind a feature flag

e4eb5ae

use dioxus web launch and remove dioxus dep completely

d23b78a

marc2332 reviewed Feb 13, 2025

View reviewed changes

Cargo.toml Show resolved Hide resolved

release 0.3.1

5db36e6

marc2332 reviewed Feb 13, 2025

View reviewed changes

marc2332 requested changes Feb 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

do not force default features on consumers #8

do not force default features on consumers #8

Niedzwiedzw commented Feb 13, 2025

matthunz commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025 •

edited

Loading

marc2332 commented Feb 13, 2025

marc2332 commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

marc2332 commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

marc2332 commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

marc2332 commented Feb 13, 2025

marc2332 commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

marc2332 commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

marc2332 commented Feb 13, 2025

marc2332 Feb 13, 2025

marc2332 Feb 13, 2025

marc2332 Feb 13, 2025

marc2332 Feb 13, 2025

marc2332 Feb 13, 2025

marc2332 Feb 13, 2025

marc2332 Feb 13, 2025

marc2332 Feb 13, 2025

	console_error_panic_hook = "0.1"
	console_error_panic_hook = "0.1"
	dioxus = { version = "0.6", features = ["web"] }

	dioxus_web::launch::launch_cfg(app, dioxus_web::Config::new())
	launch(app)

		use dioxus_lazy::{lazy, Direction, UseList};
		use dioxus_lib::prelude::*;

do not force default features on consumers #8

Are you sure you want to change the base?

do not force default features on consumers #8

Conversation

Niedzwiedzw commented Feb 13, 2025

matthunz commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025 • edited Loading

marc2332 commented Feb 13, 2025

marc2332 commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

marc2332 commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

marc2332 commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

marc2332 commented Feb 13, 2025

marc2332 commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

marc2332 commented Feb 13, 2025

Niedzwiedzw commented Feb 13, 2025

marc2332 commented Feb 13, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Niedzwiedzw commented Feb 13, 2025 •

edited

Loading