Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QUERYSTRING_MAX_PARSE_DEPTH configuration variable #24833

Merged
merged 3 commits into from
Mar 16, 2025
Merged

Add QUERYSTRING_MAX_PARSE_DEPTH configuration variable #24833

merged 3 commits into from
Mar 16, 2025

Conversation

Nitwel
Copy link
Member

@Nitwel Nitwel commented Mar 13, 2025 •
edited by licitdev
Loading

Scope

What's changed:

  • Added env var for hardcoded number

Potential Risks / Drawbacks

Review Notes / Questions

  • Let me know if there are more changes that need to be done for adding environment variables.
  • I've also tried trowing errors in case we hit the limit so it's easier to find out what's going wrong but making that throw an error causes some problems down the line with the handleError middleware so I left that as is for now.
  • Docs PR: Add QUERYSTRING_MAX_PARSE_DEPTH to docs docs#240

Fixes #24190

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: b3033d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/env Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Nitwel Nitwel marked this pull request as ready for review March 13, 2025 17:32
@Nitwel Nitwel requested a review from a team as a code owner March 13, 2025 17:32
@licitdev licitdev requested a review from br41nslug March 14, 2025 14:32
br41nslug
br41nslug approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@br41nslug br41nslug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good :) but lets not forget to add this new env var to the docs 📖

@br41nslug br41nslug mentioned this pull request Mar 14, 2025
Open
@ComfortablyCoding ComfortablyCoding changed the title Add QueryMaxDepth env var Add QUERYSTRING_MAX_PARSE_DEPTH env var Mar 16, 2025
ComfortablyCoding
ComfortablyCoding approved these changes Mar 16, 2025
View reviewed changes
Copy link
Contributor

@ComfortablyCoding ComfortablyCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ComfortablyCoding ComfortablyCoding self-assigned this Mar 16, 2025
@ComfortablyCoding ComfortablyCoding changed the title Add QUERYSTRING_MAX_PARSE_DEPTH env var Add QUERYSTRING_MAX_PARSE_DEPTH configuration variable Mar 16, 2025
@ComfortablyCoding ComfortablyCoding merged commit 3d3a233 into main Mar 16, 2025
5 checks passed
@ComfortablyCoding ComfortablyCoding deleted the fix-24190 branch March 16, 2025 14:29
@github-actions github-actions bot added this to the Next Release milestone Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@licitdev licitdev licitdev left review comments

@ComfortablyCoding ComfortablyCoding ComfortablyCoding approved these changes

@br41nslug br41nslug br41nslug approved these changes

Assignees

@ComfortablyCoding ComfortablyCoding

Labels
None yet
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

Issue with Query Depth Limitation in Filters with Multiple Groups
4 participants
@Nitwel @br41nslug @licitdev @ComfortablyCoding