Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

[DIR-1089] remove Post Start Exec from services #555

Merged
merged 2 commits into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions public/locales/en/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,7 @@
"scale": "Scale",
"size": "Size",
"cmd": "Cmd",
"envs": "Envs",
"postStartExec": "Post Start Exec"
"envs": "Envs"
}
},
"newRoute": {
Expand Down Expand Up @@ -763,8 +762,7 @@
"tableRow": {
"errorLabel": "Error",
"envsLabel": "{{count}} environment variables",
"envsLabel_one": "{{count}} environment variable",
"execLabel": "post start exec"
"envsLabel_one": "{{count}} environment variable"
},
"contextMenu": {
"rebuild": "Rebuild"
Expand Down Expand Up @@ -1597,4 +1595,4 @@
}
}
}
}
}
4 changes: 0 additions & 4 deletions src/pages/namespace/Explorer/Service/ServiceHelp.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ cmd: "redis-server" # container's cmd string (optional)
envs: # list of environment variables (optional)
- name: "MY_ENV_VAR"
value: "env-var-value"
post_start_exec: # container's post start exec array (optional)
- "/bin/sh"
- "-c"
- "echo 2 > /usr/share/message2"
`;

const ServiceHelp = () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,6 @@ export const useServiceFormSchema = (): RJSFSchema => {
title: t("pages.explorer.tree.newService.form.cmd"),
type: "string",
},
post_start_exec: {
title: t("pages.explorer.tree.newService.form.postStartExec"),
type: "array",
items: {
type: "string",
},
},
envs: {
title: t("pages.explorer.tree.newService.form.envs"),
type: "array",
Expand Down
34 changes: 0 additions & 34 deletions src/pages/namespace/Services/List/Row/PostStartExecs.tsx

This file was deleted.

2 changes: 0 additions & 2 deletions src/pages/namespace/Services/List/Row/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import Button from "~/design/Button";
import { DialogTrigger } from "~/design/Dialog";
import EnvsVariables from "./EnvVariables";
import { FC } from "react";
import PostStartExecs from "./PostStartExecs";
import { ServiceSchemaType } from "~/api/services/schema/services";
import { StatusBadge } from "../../components/StatusBadge";
import { TooltipProvider } from "~/design/Tooltip";
Expand Down Expand Up @@ -91,7 +90,6 @@ const ServicesTableRow: FC<{
</StatusBadge>
))}
<EnvsVariables envs={service.envs} />
<PostStartExecs exec={service.post_start_exec} />
</div>
</div>
</TableCell>
Expand Down