Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use biome for linting/formatting #38

Closed
wants to merge 1 commit into from
Closed

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Apr 11, 2024

eslint 9 jumped the shark and I'm tired of managing 148 dependencies

},
"javascript": {
"formatter": {
"quoteStyle": "single"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, if you want to match our primary styleguide, you'd want a formatter config more like:

{
  "formatter": {
    "indentStyle": "space",
    "indentWidth": 2,
    "lineWidth": 120
  },
  "javascript": {
    "formatter": {
      "quoteStyle": "single",
      "bracketSameLine": true,
      "bracketSpacing": false
    }
  }
}

Up to you if you want them to match or don't really mind either way (i'm all for just using defaults nowadays)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not heavily opposed to matching our style... but to your point, I just really want defaults where it makes sense. Except double quotes, I'll just never understand that as the default.

Copy link

@ykogan-discord ykogan-discord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace looks a little wild lol.

My only hesitation is that this seems like a departure from our existing tools stack. Is this a direction the tools / leverage team is on board with? I'm more conservative with this change because it's the sample app, meaning future apps may copy/pasta this config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants