Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[voice] small update for binary seq numbers #7156

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

birarda
Copy link
Contributor

@birarda birarda commented Sep 18, 2024

There's an error in the new DAVE protocol docs I added yesterday. The sequence number is always required from server -> client on binary websocket messages. I've also added a clarification that it is big-endian.

@birarda birarda requested a review from a team as a code owner September 18, 2024 19:42
@birarda birarda requested review from shaydewael and removed request for a team September 18, 2024 19:42
@JustinBeckwith JustinBeckwith merged commit 0860e4d into main Sep 19, 2024
4 checks passed
@JustinBeckwith JustinBeckwith deleted the voice/binary-ws-updates branch September 19, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants