Skip to content

Commit

Permalink
Use NDK 24.0.8215888
Browse files Browse the repository at this point in the history
This needs to be forced in a few places otherwise the build tries to pull in ndk 23
  • Loading branch information
DDRBoxman committed Feb 20, 2024
1 parent 65ee814 commit 723d2f4
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 12 deletions.
4 changes: 1 addition & 3 deletions ReactAndroid/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -528,9 +528,7 @@ android {
if (rootProject.hasProperty("ndkPath")) {
ndkPath rootProject.ext.ndkPath
}
if (rootProject.hasProperty("ndkVersion")) {
ndkVersion rootProject.ext.ndkVersion
}
ndkVersion = "24.0.8215888"

defaultConfig {
minSdkVersion(21)
Expand Down
4 changes: 1 addition & 3 deletions ReactAndroid/hermes-engine/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,7 @@ android {
if (rootProject.hasProperty("ndkPath")) {
ndkPath rootProject.ext.ndkPath
}
if (rootProject.hasProperty("ndkVersion")) {
ndkVersion rootProject.ext.ndkVersion
}
ndkVersion = "24.0.8215888"

defaultConfig {
minSdkVersion 21
Expand Down
6 changes: 2 additions & 4 deletions packages/rn-tester/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,8 @@ android {
if (rootProject.hasProperty("ndkPath")) {
ndkPath rootProject.ext.ndkPath
}
if (rootProject.hasProperty("ndkVersion")) {
ndkVersion rootProject.ext.ndkVersion
}

ndkVersion = "24.0.8215888"

flavorDimensions "vm"
productFlavors {
hermes {
Expand Down
3 changes: 1 addition & 2 deletions template/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ buildscript {
compileSdkVersion = 33
targetSdkVersion = 33

// We use NDK 23 which has both M1 support and is the side-by-side NDK version from AGP.
ndkVersion = "23.1.7779620"
ndkVersion = "24.0.8215888"
}
repositories {
google()
Expand Down

0 comments on commit 723d2f4

Please sign in to comment.