[android] implement invalidate() on WebSocketModule to match iOS #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
@nealmanaktola , I've forgotten some context around this PR. Did we decide in chat anywhere that this wasn't necessary anymore? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the react native bridge reloads,
invalidateis called on all the modules. On iOS, this cleanup is already implementedhttps://github.com/facebook/react-native/blob/main/React/CoreModules/RCTWebSocketModule.mm#L54
I'll create a PR upstream as well, not sure why this wasn't already implemented.
For our cases, this is not really required, but it's nice that during development in case the bridge reloads, you'd leave the activity/VC and won't end up in a weird state.