Conversation
sanchda
approved these changes
Mar 12, 2026
sanchda
left a comment
sanchda
left a comment
There was a problem hiding this comment.
agree; pushing dogstatsd conformance into the statix layer feels correct
Comment on lines
+22
to
+29
| "_e{", | ||
| Integer.to_string(byte_size(title_bin)), | ||
| ",", | ||
| Integer.to_string(byte_size(text_bin)), | ||
| "}:", | ||
| title_bin, | ||
| "|", | ||
| text_bin |
There was a problem hiding this comment.
Verifying that this is correct according to the dogstatsd event specification. We could support more here, but I don't think we have much need for the additional fields at the application layer yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instruments can send events to Datadog, but relied on the fact that Statix was using a UDP endpoint. This breaks down when Unix Domain Sockets are used, so this PR moves that emission into Statix itself. This code is mostly a port of the existing
send_eventfunction in Instruments.This does add a function to the
Statixbehavior, but theusemacro provides a default implementation, so I don't consider this a breaking change.Quick screenshot showing the events themselves are picked up by Datadog:
