Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: webhook events #1128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: webhook events #1128

wants to merge 1 commit into from
+704 −4

Conversation

sdanialraza
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

@sdanialraza sdanialraza requested review from a team as code owners October 30, 2024 16:41
@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 11:40pm

@imnaiyar imnaiyar mentioned this pull request Nov 1, 2024
Draft
vladfrangu
vladfrangu requested changes Nov 4, 2024
View reviewed changes
deno/payloads/v10/application.ts Outdated Show resolved Hide resolved
deno/payloads/v10/application.ts Outdated Show resolved Hide resolved
deno/payloads/v10/webhook.ts Outdated
/**
* Data for the event. The shape depends on the event type
*/
data?: unknown;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we know the data type based on the WebhookEventType, and should type it as such? If we do, please replicate similar to interactions 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu requested changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
topic:payloads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdanialraza @vladfrangu