Fix panic when tmp path is inccurate #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch still valid) and add test-case for it Signed-off-by: s1gnate-sync <[email protected]>
|
@deitch had intense sprint and didn't have energy to finish with test-case. Now it's done and I've checked first that test is failing and when added clean to the path and rerun test to ensure it's not failing anymore! All seems good. There is tiny thing I forgot to add empty line between functions in |
deitch
previously approved these changes
Feb 17, 2025
|
Lint doesn't like how you structured the test. |
Signed-off-by: s1gnate-sync <[email protected]>
|
I've looked how it's handled in other tests and did the same, seems like this rule is useless. I've also added that empty string! |
deitch
approved these changes
Feb 19, 2025
|
@deitch thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prior this fix if TMPDIR is set to something like
/tmp//the iso9660 creation would cause panic.now it's fixed + test case is added according to @Dietch review