Skip to content

Convert initial value that comes as int to a list of flag names. #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zaxl wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Convert initial value that comes as int to a list of flag names. #32

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
129d0f5
Convert initial value that comes as int to a list of flag names.
Jun 10, 2013
f81909e
fix indent
Jun 10, 2013
d8f7a8c
fix indent take two
Jun 10, 2013
7a6ca66
Style cleanup. Check if initial is in kwargs.
Jun 10, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions bitfield/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ def _has_changed(self, initial, data):

class BitFormField(IntegerField):
def __init__(self, choices=(), widget=BitFieldCheckboxSelectMultiple, *args, **kwargs):
if isinstance(kwargs['initial'],int):
Copy link
Copy Markdown
Collaborator

@dcramer dcramer Jun 10, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a space after the comma

also initial isnt guaranteed to be in kwargs

iv = kwargs['initial']
l = []
for i in range(0, 63):
Copy link
Copy Markdown
Collaborator

@dcramer dcramer Jun 10, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xrange

if (1<<i) & iv > 0:
Copy link
Copy Markdown
Collaborator

@dcramer dcramer Jun 10, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space around operations if (1 << i)

l += [choices[i][0]]
kwargs['initial'] = l
self.widget = widget
super(BitFormField, self).__init__(widget=widget, *args, **kwargs)
self.choices = self.widget.choices = choices
Expand Down