-
-
Notifications
You must be signed in to change notification settings - Fork 1
chore(deps): update dependency vite to v5 [security] #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
saga
Choose a base branch
from
renovate/npm-vite-vulnerability
base: saga
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch automerge failureThis PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.
|
3e1f34f to
fe31eb9
Compare
fe31eb9 to
88541f1
Compare
88541f1 to
e59f70a
Compare
e59f70a to
7a799dd
Compare
7a799dd to
2287a53
Compare
2287a53 to
869e0a9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.5.5->5.4.21GitHub Vulnerability Alerts
CVE-2025-24010
Summary
Vite allowed any websites to send any requests to the development server and read the response due to default CORS settings and lack of validation on the Origin header for WebSocket connections.
Warning
This vulnerability even applies to users that only run the Vite dev server on the local machine and does not expose the dev server to the network.
Upgrade Path
Users that does not match either of the following conditions should be able to upgrade to a newer version of Vite that fixes the vulnerability without any additional configuration.
localhostor*.localhostUsing the backend integration feature
If you are using the backend integration feature and not setting
server.origin, you need to add the origin of the backend server to theserver.cors.originoption. Make sure to set a specific origin rather than*, otherwise any origin can access your development server.Using a reverse proxy in front of Vite
If you are using a reverse proxy in front of Vite and sending requests to Vite with a hostname other than
localhostor*.localhost, you need to add the hostname to the newserver.allowedHostsoption. For example, if the reverse proxy is sending requests tohttp://vite:5173, you need to addviteto theserver.allowedHostsoption.Accessing the development server via a domain other than
localhostor*.localhostYou need to add the hostname to the new
server.allowedHostsoption. For example, if you are accessing the development server viahttp://foo.example.com:8080, you need to addfoo.example.comto theserver.allowedHostsoption.Using a plugin / framework that connects to the WebSocket server on their own from the browser
If you are using a plugin / framework, try upgrading to a newer version of Vite that fixes the vulnerability. If the WebSocket connection appears not to be working, the plugin / framework may have a code that connects to the WebSocket server on their own from the browser.
In that case, you can either:
legacy.skipWebSocketTokenCheck: trueto opt-out the fix for [2] while the plugin / framework is incompatible with the new version of ViteMitigation without upgrading Vite
[1]: Permissive default CORS settings
Set
server.corstofalseor limitserver.cors.originto trusted origins.[2]: Lack of validation on the Origin header for WebSocket connections
There aren't any mitigations for this.
[3]: Lack of validation on the Host header for HTTP requests
Use Chrome 94+ or use HTTPS for the development server.
Details
There are three causes that allowed malicious websites to send any requests to the development server:
[1]: Permissive default CORS settings
Vite sets the
Access-Control-Allow-Originheader depending onserver.corsoption. The default value wastruewhich setsAccess-Control-Allow-Origin: *. This allows websites on any origin tofetchcontents served on the development server.Attack scenario:
http://malicious.example.com).fetch('http://127.0.0.1:5173/main.js')request by JS in that malicious web page. This request is normally blocked by same-origin policy, but that's not the case for the reasons above.http://127.0.0.1:5173/main.js.[2]: Lack of validation on the Origin header for WebSocket connections
Vite starts a WebSocket server to handle HMR and other functionalities. This WebSocket server did not perform validation on the Origin header and was vulnerable to Cross-Site WebSocket Hijacking (CSWSH) attacks. With that attack, an attacker can read and write messages on the WebSocket connection. Vite only sends some information over the WebSocket connection (list of the file paths that changed, the file content where the errored happened, etc.), but plugins can send arbitrary messages and may include more sensitive information.
Attack scenario:
http://malicious.example.com).new WebSocket('http://127.0.0.1:5173', 'vite-hmr')by JS in that malicious web page.[3]: Lack of validation on the Host header for HTTP requests
Unless
server.httpsis set, Vite starts the development server on HTTP. Non-HTTPS servers are vulnerable to DNS rebinding attacks without validation on the Host header. But Vite did not perform validation on the Host header. By exploiting this vulnerability, an attacker can send arbitrary requests to the development server bypassing the same-origin policy.http://malicious.example.com:5173) (HTTPS won't work).fetch('/main.js')request by JS in that malicious web page.http://127.0.0.1:5173/main.jsbypassing the same origin policy.Impact
[1]: Permissive default CORS settings
Users with the default
server.corsoption may:server.proxymay have those functionalities.[2]: Lack of validation on the Origin header for WebSocket connections
All users may get the file paths of the files that changed and the file content where the error happened be stolen by malicious websites.
For users that is using a plugin that sends messages over WebSocket, that content may be stolen by malicious websites.
For users that is using a plugin that has a functionality that is triggered by messages over WebSocket, that functionality may be exploited by malicious websites.
[3]: Lack of validation on the Host header for HTTP requests
Users using HTTP for the development server and using a browser that is not Chrome 94+ may:
server.proxymay have those functionalities.Chrome 94+ users are not affected for [3], because sending a request to a private network page from public non-HTTPS page is forbidden since Chrome 94.
Related Information
Safari has a bug that blocks requests to loopback addresses from HTTPS origins. This means when the user is using Safari and Vite is listening on lookback addresses, there's another condition of "the malicious web page is served on HTTP" to make [1] and [2] to work.
PoC
[2]: Lack of validation on the Origin header for WebSocket connections
reacttemplate which utilizes HMR functionality.http://localhost:5173/) as well as the malicious page in the browser.src/App.jsxfile and intentionally place a syntax errorHere's a video demonstrating the POC:
vite-cswsh.mov
CVE-2025-30208
Summary
The contents of arbitrary files can be returned to the browser.
Impact
Only apps explicitly exposing the Vite dev server to the network (using
--hostorserver.hostconfig option) are affected.Details
@fsdenies access to files outside of Vite serving allow list. Adding?raw??or?import&raw??to the URL bypasses this limitation and returns the file content if it exists. This bypass exists because trailing separators such as?are removed in several places, but are not accounted for in query string regexes.PoC
CVE-2025-62522
Summary
Files denied by
server.fs.denywere sent if the URL ended with\when the dev server is running on Windows.Impact
Only apps that match the following conditions are affected:
server.hostconfig option)Details
server.fs.denycan contain patterns matching against files (by default it includes.env,.env.*,*.{crt,pem}as such patterns). These patterns were able to bypass by using a back slash(\). The root cause is thatfs.readFile('/foo.png/')loads/foo.png.PoC
Release Notes
vitejs/vite (vite)
v5.4.21Compare Source
Please refer to CHANGELOG.md for details.
v5.4.20Compare Source
Please refer to CHANGELOG.md for details.
v5.4.19Compare Source
Please refer to CHANGELOG.md for details.
v5.4.18Compare Source
Please refer to CHANGELOG.md for details.
v5.4.17Compare Source
Please refer to CHANGELOG.md for details.
v5.4.16Compare Source
Please refer to CHANGELOG.md for details.
v5.4.15Compare Source
Please refer to CHANGELOG.md for details.
v5.4.14Compare Source
Please refer to CHANGELOG.md for details.
v5.4.13Compare Source
Please refer to CHANGELOG.md for details.
v5.4.12Compare Source
This version contains a breaking change due to security fixes. See GHSA-vg6x-rcgg-rjx6 for more details.
Please refer to CHANGELOG.md for details.
v5.4.11Compare Source
Today, we're taking another big step in Vite's story. The Vite team, contributors, and ecosystem partners are excited to announce the release of the next Vite major:
We want to thank the more than 1K contributors to Vite Core and the maintainers and contributors of Vite plugins, integrations, tools, and translations that have helped us craft this new major. We invite you to get involved and help us improve Vite for the whole ecosystem. Learn more at our Contributing Guide.
⚠ BREAKING CHANGES
file://resolution (#18422)build.cssMinifyto'esbuild'for SSR (#15637)json.stringify: 'auto'and make that the default (#18303)fast-globtotinyglobby(#18243)Features
module-synccondition when loading config if enabled (#18650) (cf5028d)isSsrTargetWebWorkerflag toconfigEnvironmenthook (#18620) (3f5fab0)ssr.resolve.mainFieldsoption (#18646) (a6f5f5b)platformoption (#18611) (0924879)?inlineand?no-inlinequeries to control inlining (#15454) (9162172)vite-ignoreattribute to opt-out of processing (#18494) (d951310)file://resolution (#18422) (6a7e313)consoleincreateLogger(#18379) (0c497d9)sec-fetch-destheader to detect JS in transform (#9981) (e51dc40)json.stringify: 'auto'and make that the default (#18303) (b80daa7)environment::listen(#18263) (4d5f51d)this.environmentinoptionsandonLoghook (#18142) (7722c06)EnvironmentOptionstype (#18080) (35cf59c)Bug Fixes
createRunnableDevEnvironmentreturnsRunnableDevEnvironment, notDevEnvironment(#18673) (74221c3)getModulesByFileshould return aserverModule(#18715) (b80d5ec)SIGTERM(#18741) (cc55e36)InterceptorOptionstype (#18766) (6252c60)__vite_ssr_identity__with(0, ...)and inject;between statements (#18748) (94546be)rollup.externalscripts correctly (#18618) (55461b4)ssrTransformparse error (#18644) (d9be921)consumer: 'server'(#18575) (87b2347)server.perEnvironmentStartEndDuringDev(#18549) (fe30349)optimizeDeps.includefor SSR (#18506) (826c81a)new URL(,import.meta.url)match (#18194) (5286a90)cssCodeSplituses the current environment configuration (#18486) (eefe895)json.stringifyarrays (#18541) (fa50b03)[@import](https://redirect.github.com/import) url(...)(#17857) (aec5fdd)definein environment config was not working (#18515) (052799e)cssCodeSplitinenvironments.xxx.buildis invalid (#18464) (993e71c)CSSOptions.preprocessorOptions(#18001) (7eeb6f2)build.cssMinifyto'esbuild'for SSR (#15637) (f1d3bf7)--watchshould not overridebuild.watchoptions (#18390) (b2965c8)opendependency to 10.1.0 (#18349) (5cca4bf)thisin exported function should beundefined(#18329) (bae6a37)output.formatwithworker.formaton worker build error (#18165) (dc82334)injectQuerydouble encoding (#18246) (2c5f948)conditionsand more (#18302) (2017a33)defineConfig(#18299) (94e34cf)this.hot.closefor non-ws HotChannel (#18212) (bad0ccc)data:(#18241) (ec0efe8)sharedPlugins(#18214) (34041b9)webCompatible(#18221) (a44b0a2)HMRConnection.sendon implementation side (#18186) (9470011)config.consumerinstead ofoptions?.ssr/config.build.ssr(#18140) (21ec1ce)getRelativeUrlFromDocument(#18115) (ade1d89)script modulein svelte (#18063) (7d699aa)preload-helperhas no side effects (#18057) (587ad7b)ssrModuleandssrError(#18031) (cf8ced5)Performance Improvements
Object.keys(import.meta.glob(...))/Object.values(import.meta.glob(...))(#18666) (ed99a2c)module.enableCompileCache()(#18323) (18f1dad)crypto.hashwhen available (#18317) (2a14884)Documentation
HotUpdateContexttoHotUpdateOptions(#18718) (824c347)Reverts
Miscellaneous Chores
/mapping inresolve.alias(#18588) (a51c254)Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.