Branch app entry point to support both legacy and beta versions #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the beta CLI - adds a `--legacy (-l)` CLI option that forces the application to run in legacy mode. - adds a new warning message when the CLI is run in legacy mode.
Contributor
|
@jaerod95 Are there docs somewhere for how to run the local cli? I tried searching in notion but didn't find much and what I did find was really old so not sure if it's still accurate. I will test this out for my own understanding, but I don't feel comfortable signing off on this PR when I've never used the legacy cli before. I think someone who knows what it's meant to look like/how it works should test this PR to ensure it still works properly. |
marla-hoggard
approved these changes
Apr 8, 2025
Co-authored-by: Marla Hoggard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves Legacy CLI into a
legacyfolder and provides a new entrypoint to the beta CLI--legacy (-l)CLI option that forces the application to run in legacy mode.Overview
Creates separate entrypoints for the CLI application to support legacy and beta versions. The CLI now runs pointed at the beta API by default in the upcoming 5.0 version. Passing in a new
--legacy (-l)flag boots the CLI into a version supporting legacy configurations.Additionally, this PR moves all legacy implementation code into a
lib/legacydirectory. All new source code will be written in thelib/srcdirectory to provide full flexibility to rebuild the CLI from the ground up.Test Plan
yarn start --legacyboots the application into the legacy version of the CLI. A warning message should log to the output.--legacyflag (test pull)--legacyflag should boot the application into beta mode. Currently only the--helpcommand is supported.