Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance RedirectsPanel with customizable redirect response hook #2104

Merged
merged 6 commits into from
Mar 20, 2025

Conversation

blingblin-g
Copy link
Member

@blingblin-g blingblin-g commented Mar 12, 2025

Description

This PR introduces a hook in the RedirectsPanel to allow subclasses to customize the redirect response. This enhancement enables developers to extend the panel's functionality without modifying the base class, providing more flexibility in handling redirect responses.

The motivation behind this change is to improve the extensibility of the RedirectsPanel and provide a way for developers to capture and process additional information from the original response during redirects.

Fixes #1679

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

@blingblin-g blingblin-g self-assigned this Mar 12, 2025
@blingblin-g blingblin-g marked this pull request as ready for review March 13, 2025 14:47
@tim-schilling
Copy link
Member

As per Djangonaut Space call:

  • Matthias suggested adding a note to the RedirectsPanel documentation

@matthiask matthiask merged commit 0924116 into django-commons:main Mar 20, 2025
25 checks passed
@matthiask
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Original response is lost when redirection is intercepted
3 participants