Install permission #208
Merged
Install permission #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/django-typer into install_permission
…o-typer into install_permission
…s/django-typer into install_permission
…errides the ansi codes anyway
…s/django-typer into install_permission
There was a problem hiding this comment.
Pull Request Overview
This PR aims to update the installation functions across multiple shell modules by incorporating an optional prompt before editing user configuration files, and adjusting return types accordingly. Key changes include:
- Changing install methods to accept a prompt parameter and to return a list of edited files.
- Updating shell-specific logic for zsh, PowerShell, fish, and bash along with related helper methods.
- Adjusting workflow configurations and updating subprocess commands in plugin backups.
Reviewed Changes
Copilot reviewed 42 out of 47 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/django_typer/shells/zsh.py | Updated install method signature and logic to support prompting and multiple edited files. |
| src/django_typer/shells/powershell.py | Modified install to support prompts and return multiple paths. |
| src/django_typer/shells/fish.py | Changed install to prompt before writing and return a list of paths. |
| src/django_typer/shells/bash.py | Revised install to append source lines conditionally with prompts. |
| src/django_typer/shells/init.py | Added translation support, rich_console, and prompt helper; updated rendering logic. |
| src/django_typer/management/commands/shellcompletion.py | Updated install command parameters and docstrings to match new install signatures. |
| src/django_typer/completers/* | Minor changes to documentation and helper function types. |
| pyproject.toml | Adjusted dependency formatting. |
| examples/plugins/my_app/management/plugins/backup_typer.py, backup.py | Updated subprocess calls from “pip” to “uv pip” freeze. |
| Workflow files (.github/workflows/*) | Updated Django versions, Python version, and test commands. |
Files not reviewed (5)
- doc/source/changelog.rst: Language not supported
- doc/source/reference/completers.rst: Language not supported
- doc/source/reference/shells.rst: Language not supported
- doc/source/shell_completion.rst: Language not supported
- justfile: Language not supported
Comments suppressed due to low confidence (1)
src/django_typer/shells/init.py:300
- The attribute 'self.name' is used as the language parameter for Syntax but is not defined in the class; consider using an existing attribute (for example, 'self.prog_name') or defining 'self.name'.
syntax = Syntax(source, self.name, theme="monokai", start_line=start_line, line_numbers=False)
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.