Reduce shellcompletion CI test times#293
Open
bckohan wants to merge 11 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the shellcompletion test harness to avoid fixed sleep() delays by introducing sentinel/quiescence-based polling and by reusing a long-running shell process per test, reducing CI runtime and flakiness for interactive completion tests.
Changes:
- Removed the prior FD timeout reader helper and replaced it with a general
_wait_for()polling utility. - Added per-test shell process reuse with explicit invalidation on install/remove/teardown.
- Reworked PTY read/write plumbing on Windows and POSIX to support sentinel-based readiness waits.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+61
to
+65
| start = time.time() | ||
| last_data = time.time() | ||
| seen = sentinel is None | ||
| while time.time() - start < timeout: | ||
| data = read_fn() |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
… speed up shell completion tests
…hell working again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor shellcompletion tests so they don't rely on waits.