Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the format_errors bug when response data is None #1229

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ericinfins
Copy link

@ericinfins ericinfins commented May 31, 2024

Fixes #

Related to the PR: #1121
Add the test case to support it

Description of the Change

Fix: TypeError: object of type 'NoneType' has no len()

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@ericinfins ericinfins changed the title fix the format_errors bug when data is None Fix the format_errors bug when response data is None May 31, 2024
@sliverc
Copy link
Member

sliverc commented Jun 6, 2024

Thanks for following up on this. I will take a look at it at some point and will give you feedback. Just writing to let you know that I saw it.

@sliverc
Copy link
Member

sliverc commented Aug 31, 2024

I have finally got around to take a look at this. Great to see how this can be reproduced by using vanilla DRF classes.

It is though as I expected that this fix does avoid the exception, however the output of the fix is not JSON:API compliant. It simply returns

{
  "errors": None
}

but the value of errors needs to be a list and each error object must at least have one member. I think the easiest is to add a single error object with the status code as a string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants