chore: update help_text for client_secret

[lrq315]

Fixes #1628

Description of the Change

• Corrected the help text for the client_secret field. The previous description (“Hashed on Save”) was inaccurate because hashing is only performed when hash_client_secret is True.

Checklist

• PR only contains one change (considered splitting up PR)
• unit-test added
• documentation updated
• CHANGELOG.md updated (only for user relevant changes)
• author name in AUTHORS
• tests/app/idp updated to demonstrate new features
• tests/app/rp updated to demonstrate new features

[n2ygk]

Wow, that's a lot of changes. @dopry are you OK with this much code change to implement this relatively minor UI fix?

Also please wait on #1631 to be merged and rebase to resolve the failed 3.14 test.

[lrq315]

Sorry—looking back, it does seem that the changes may have been a bit over-scoped. I should have checked with you on the scope in advance. Please feel free to let me revert the form changes and just update the text directly.

As for the other E2E test IdP mitigations, I think they might still be helpful for others.

[dopry]

@lrq315 there is too much out of scope work in this PR. Per the checklist PR only contains one change (considered splitting up PR) please split up the PR into consumable chunks that are easy to validate for use.

[lrq315]

Hello @dopry, thanks for the suggestion — I’ve updated the PR to include only the text changes now. Could you please help review? Other formatting changes are handled by pre-commit. I will raise new issues and related PRs later.

update: #1634 #1635

I personally think the current PR should be released together with #1635

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!